Issue 6353089: Forced GrClip to always have conservative bounds

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6353089: Forced GrClip to always have conservative bounds (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 12 months ago by robertphillips

Modified:
11 years, 12 months ago

Reviewers:
bsalomon

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

First portion of replacing GrClip w\ SkClipStack refactoring.

Patch Set 1 #

Total comments: 2

Created: 11 years, 12 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+56 lines, -69 lines)			Patch
M	gm/texdata.cpp	View	1 chunk	+3 lines, -1 line	2 comments	Download
M	include/gpu/GrClip.h	View	2 chunks	+9 lines, -9 lines	0 comments	Download
M	src/gpu/GrAAHairLinePathRenderer.cpp	View	1 chunk	+1 line, -6 lines	0 comments	Download
M	src/gpu/GrClip.cpp	View	3 chunks	+4 lines, -4 lines	0 comments	Download
M	src/gpu/GrClipMaskManager.cpp	View	2 chunks	+12 lines, -23 lines	0 comments	Download
M	src/gpu/GrContext.cpp	View	2 chunks	+8 lines, -3 lines	0 comments	Download
M	src/gpu/GrSoftwarePathRenderer.cpp	View	1 chunk	+5 lines, -8 lines	0 comments	Download
M	src/gpu/GrTextContext.cpp	View	1 chunk	+8 lines, -11 lines	0 comments	Download
M	src/gpu/SkGpuDevice.cpp	View	2 chunks	+5 lines, -2 lines	0 comments	Download
M	src/gpu/gl/GrGpuGL_program.cpp	View	1 chunk	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

robertphillips

http://codereview.appspot.com/6353089/diff/1/gm/texdata.cpp File gm/texdata.cpp (right): http://codereview.appspot.com/6353089/diff/1/gm/texdata.cpp#newcode91 gm/texdata.cpp:91: Although it looks odd here, once GrClip is replaced ...

11 years, 12 months ago (2012-07-11 17:51:50 UTC) #1

bsalomon

LGTM http://codereview.appspot.com/6353089/diff/1/gm/texdata.cpp File gm/texdata.cpp (right): http://codereview.appspot.com/6353089/diff/1/gm/texdata.cpp#newcode91 gm/texdata.cpp:91: On 2012/07/11 17:51:50, robertphillips wrote: > Although it ...

11 years, 12 months ago (2012-07-11 18:11:53 UTC) #2

committed as r4545

Expand All Messages | Collapse All Messages