Issue 6353083: More carefully disable states

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6353083: More carefully disable states (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 6 months ago by TomH

Modified:
12 years, 6 months ago

Reviewers:
bsalomon

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Description

Close up possible bug in GrContext::setPaint(). Other places we should consider doing this? GrSWMaskHelper::DrawToTargetWithPathMask(), GrTextContext::flushGlyphs(), GrClipMaskManager::drawTexture().

Patch Set 2 : Fix nit, disable more stages #

Created: 12 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -6 lines)			Patch
M	src/gpu/GrClipMaskManager.cpp	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/gpu/GrContext.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/gpu/GrDrawState.h	View	1	1 chunk	+7 lines, -2 lines	0 comments	Download
M	src/gpu/GrSWMaskHelper.cpp	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/gpu/GrTextContext.cpp	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

bsalomon

modulo nit, LGTM http://codereview.appspot.com/6353083/diff/1/src/gpu/GrDrawState.h File src/gpu/GrDrawState.h (right): http://codereview.appspot.com/6353083/diff/1/src/gpu/GrDrawState.h#newcode240 src/gpu/GrDrawState.h:240: disableStage(i); this->

12 years, 6 months ago (2012-07-10 16:22:26 UTC) #2

bsalomon

On 2012/07/10 17:18:41, TomH wrote: > Nit fixed, disableStage() spammed. LGTM

12 years, 6 months ago (2012-07-10 17:20:11 UTC) #4

Closed with r4510.

Expand All Messages | Collapse All Messages