Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(7667)

Issue 6353079: Document use of alignAboveContext and alignBelowContext (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 9 months ago by Trevor Daniels
Modified:
11 years, 9 months ago
Reviewers:
Graham Percival, phileholmes, t.daniels
CC:
lilypond-user_gnu.org, lilypond-devel_gnu.org
Base URL:
http://git.savannah.gnu.org/gitweb/?p=lilypond.git/trunk/
Visibility:
Public.

Description

Document use of alignAboveContext and alignBelowContext (2557)

Patch Set 1 #

Total comments: 7

Patch Set 2 : Respond to Graham's comments #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -0 lines) Patch
M Documentation/notation/changing-defaults.itely View 1 1 chunk +36 lines, -0 lines 1 comment Download
M Documentation/notation/vocal.itely View 1 1 chunk +48 lines, -0 lines 0 comments Download

Messages

Total messages: 6
PhilEHolmes
One suggestion, otherwise LGTM. Thanks. http://codereview.appspot.com/6353079/diff/1/Documentation/notation/vocal.itely File Documentation/notation/vocal.itely (right): http://codereview.appspot.com/6353079/diff/1/Documentation/notation/vocal.itely#newcode1327 Documentation/notation/vocal.itely:1327: One for Graham really, ...
11 years, 9 months ago (2012-07-06 11:21:13 UTC) #1
Graham Percival
http://codereview.appspot.com/6353079/diff/1/Documentation/notation/changing-defaults.itely File Documentation/notation/changing-defaults.itely (right): http://codereview.appspot.com/6353079/diff/1/Documentation/notation/changing-defaults.itely#newcode1024 Documentation/notation/changing-defaults.itely:1024: @code{\new Staff \with @{ alignAboveContext = #"main" @} } ...
11 years, 9 months ago (2012-07-08 04:02:42 UTC) #2
Trevor Daniels
http://codereview.appspot.com/6353079/diff/1/Documentation/notation/changing-defaults.itely File Documentation/notation/changing-defaults.itely (right): http://codereview.appspot.com/6353079/diff/1/Documentation/notation/changing-defaults.itely#newcode1024 Documentation/notation/changing-defaults.itely:1024: @code{\new Staff \with @{ alignAboveContext = #"main" @} } ...
11 years, 9 months ago (2012-07-08 08:04:42 UTC) #3
Graham Percival
LGTM. Ignore my other message that talked about using git-cl to upload an edited patch; ...
11 years, 9 months ago (2012-07-09 04:55:20 UTC) #4
t.daniels_treda.co.uk
<graham@percival-music.ca> wrote Monday, July 09, 2012 5:55 AM > Ignore my other message that talked ...
11 years, 9 months ago (2012-07-09 09:00:10 UTC) #5
Trevor Daniels
11 years, 9 months ago (2012-07-11 07:01:56 UTC) #6
Patch pushed
bcd9d85bfc1dd6cc2dd3e98901b4df33fd6d0989
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b