Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(387)

Issue 6353065: Modify gyp to only build executables as shared libraries on Android (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 5 months ago by EricB
Modified:
12 years, 5 months ago
Reviewers:
epoger, DerekS
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/android/
Visibility:
Public.

Description

Modify gyp to only build executables as shared libraries on Android Previously, all "console" targets became shared libraries, including phony targets intented just to build other executables. Only change the build type of executables --> shared libraries. This causes the 'tools' executables to properly build as shared libs. Committed: https://code.google.com/p/skia/source/detail?r=4451

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M gyp/skia_android.gypi View 1 chunk +5 lines, -1 line 1 comment Download

Messages

Total messages: 4
EricB
Need to follow this with http://codereview.appspot.com/6353066/
12 years, 5 months ago (2012-07-03 15:30:54 UTC) #1
DerekS
On 2012/07/03 15:30:54, EricB wrote: > Need to follow this with http://codereview.appspot.com/6353066/ lgtm
12 years, 5 months ago (2012-07-03 15:57:39 UTC) #2
epoger
http://codereview.appspot.com/6353065/diff/1/gyp/skia_android.gypi File gyp/skia_android.gypi (right): http://codereview.appspot.com/6353065/diff/1/gyp/skia_android.gypi#newcode55 gyp/skia_android.gypi:55: ['_type == "executable"', { Where does this _type variable ...
12 years, 5 months ago (2012-07-09 13:57:24 UTC) #3
EricB
12 years, 5 months ago (2012-07-09 14:02:51 UTC) #4
On 2012/07/09 13:57:24, epoger wrote:
> http://codereview.appspot.com/6353065/diff/1/gyp/skia_android.gypi
> File gyp/skia_android.gypi (right):
> 
> http://codereview.appspot.com/6353065/diff/1/gyp/skia_android.gypi#newcode55
> gyp/skia_android.gypi:55: ['_type == "executable"', {
> Where does this _type variable come from?  Is it special gyp magic?
> 
> This is the only place where we refer to it...
> $ grep -r _type android/gyp/*
> android/gyp/skia_android.gypi:          ['_type == "executable"', {

This is indeed gyp magic.  From the documentation:
http://code.google.com/p/gyp/wiki/InputFormatReference#Variables

Read the 'automatic variables' bullet point.  This is an automatically-defined
variable which refers to the target type that we've specified.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b