Issue 6353047: Separated Inst counting from the SK_DEBUG #define (now SK_INST_COUNT)

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6353047: Separated Inst counting from the SK_DEBUG #define (now SK_INST_COUNT) (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 5 months ago by robertphillips

Modified:
12 years, 5 months ago

Reviewers:
bsalomon, reed1

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

This change will allow instance counting to be used in release builds and will allow delivery of the atexit change (http://codereview.appspot.com/6348043/) w/o having printouts appear for every application.

Patch Set 1 #

Patch Set 2 : Changed name of #define & documented in SkUserConfig.h #

Created: 12 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+34 lines, -3 lines)			Patch
M	gm/gmmain.cpp	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download
M	gyp/common.gypi	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	gyp/core.gyp	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	include/config/SkUserConfig.h	View	1	1 chunk	+6 lines, -0 lines	0 comments	Download
M	include/core/SkInstCnt.h	View	1	3 chunks	+5 lines, -3 lines	0 comments	Download
A	src/core/SkInstCnt.cpp	View	1	1 chunk	+12 lines, -0 lines	0 comments	Download
M	tests/GrMemoryPoolTest.cpp	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 7

Expand All Messages | Collapse All Messages

bsalomon

I'm going to toss this one over to Mike since it adds a new SK_ ...

12 years, 5 months ago (2012-06-27 19:08:02 UTC) #2

reed1

will want to add a commented-out example in SkUserConfig.h, to help document this.

12 years, 5 months ago (2012-06-27 19:09:39 UTC) #4

robertphillips

Changed to #define's name & documented in SkUserConfig.h

12 years, 5 months ago (2012-06-27 19:24:42 UTC) #5

committed as r4376

Expand All Messages | Collapse All Messages