oauth2client support for URL-encoded format of exchange token response (e.g. Facebook)

Filed as Issue 162 on code hosting:
http://code.google.com/p/google-api-python-client/issues/detail?id=162

[jcgregorio_google, 2012-07-09 20:15:06]

The file test_oauth2clicent.py seemed to disappear with the second upload.
Please specify --rev to upload-diffs.py to get all your changes uploaded
together.

Also, have you signed the CLA yet?

  http://code.google.com/p/google-api-python-client/wiki/BecomingAContributor

  Thanks,
  -joe

http://codereview.appspot.com/6352088/diff/1/tests/test_oauth2client.py
File tests/test_oauth2client.py (right):

http://codereview.appspot.com/6352088/diff/1/tests/test_oauth2client.py#newco...
tests/test_oauth2client.py:282: def test_urlencoded_expires(self):
This test just appears to repeat a subset of the test above, so it can be
dropped.

http://codereview.appspot.com/6352088/diff/1/tests/test_oauth2client.py#newco...
tests/test_oauth2client.py:288: self.assertNotEqual(None,
credentials.token_expiry)
Please add a test for when parsing the URL encoded body fails.

[alexv, 2012-07-09 21:42:45]

On 2012/07/09 20:15:06, jcgregorio_google wrote:
> The file test_oauth2clicent.py seemed to disappear with the second upload.
> Please specify --rev to upload-diffs.py to get all your changes uploaded
> together.

Should be OK now (Set 3)

> 
> Also, have you signed the CLA yet?
> 
>   http://code.google.com/p/google-api-python-client/wiki/BecomingAContributor

Yep. A few hours ago. Don't know whether it's processed already, but registered
for sure.

> 
>   Thanks,
>   -joe
> 
> http://codereview.appspot.com/6352088/diff/1/tests/test_oauth2client.py
> File tests/test_oauth2client.py (right):
> 
>
http://codereview.appspot.com/6352088/diff/1/tests/test_oauth2client.py#newco...
> tests/test_oauth2client.py:282: def test_urlencoded_expires(self):
> This test just appears to repeat a subset of the test above, so it can be
> dropped.
> 
>
http://codereview.appspot.com/6352088/diff/1/tests/test_oauth2client.py#newco...
> tests/test_oauth2client.py:288: self.assertNotEqual(None,
> credentials.token_expiry)
> Please add a test for when parsing the URL encoded body fails.

[alexv, 2012-07-09 21:43:21]

http://codereview.appspot.com/6352088/diff/1/tests/test_oauth2client.py
File tests/test_oauth2client.py (right):

http://codereview.appspot.com/6352088/diff/1/tests/test_oauth2client.py#newco...
tests/test_oauth2client.py:282: def test_urlencoded_expires(self):
On 2012/07/09 20:15:06, jcgregorio_google wrote:
> This test just appears to repeat a subset of the test above, so it can be
> dropped.

Note the "expires" param instead of a normal "expires_in". I'll put some
comments or change the test name so it'll be more descriptive.

[alexv, 2012-07-09 21:53:33]

http://codereview.appspot.com/6352088/#ps8001

http://codereview.appspot.com/6352088/diff/1/tests/test_oauth2client.py
File tests/test_oauth2client.py (right):

http://codereview.appspot.com/6352088/diff/1/tests/test_oauth2client.py#newco...
tests/test_oauth2client.py:288: self.assertNotEqual(None,
credentials.token_expiry)
On 2012/07/09 20:15:06, jcgregorio_google wrote:
> Please add a test for when parsing the URL encoded body fails.

Done. I guess.

[jcgregorio_google, 2012-07-10 20:00:45]

http://codereview.appspot.com/6352088/diff/8001/oauth2client/client.py
File oauth2client/client.py (right):

http://codereview.appspot.com/6352088/diff/8001/oauth2client/client.py#newcod...
oauth2client/client.py:897: resp = None
resp = {}

http://codereview.appspot.com/6352088/diff/8001/oauth2client/client.py#newcod...
oauth2client/client.py:902: # so we just do a catch-all here
Make that StandardError so keyboard interrupts still work:
http://docs.python.org/library/exceptions.html#exceptions.StandardError

[alexv, 2012-07-10 21:18:26]

TBR: http://codereview.appspot.com/6352088/#ps18001

http://codereview.appspot.com/6352088/diff/8001/oauth2client/client.py
File oauth2client/client.py (right):

http://codereview.appspot.com/6352088/diff/8001/oauth2client/client.py#newcod...
oauth2client/client.py:897: resp = None
On 2012/07/10 20:00:45, jcgregorio_google wrote:
> resp = {}

Oops. Done.

http://codereview.appspot.com/6352088/diff/8001/oauth2client/client.py#newcod...
oauth2client/client.py:902: # so we just do a catch-all here
On 2012/07/10 20:00:45, jcgregorio_google wrote:
> Make that StandardError so keyboard interrupts still work:
> http://docs.python.org/library/exceptions.html#exceptions.StandardError

Done.

[jcgregorio_google, 2012-07-11 14:38:21]

Very close, just nits now.

http://codereview.appspot.com/6352088/diff/18001/oauth2client/client.py
File oauth2client/client.py (right):

http://codereview.appspot.com/6352088/diff/18001/oauth2client/client.py#newco...
oauth2client/client.py:885: """
Reformat doc string to look like:

"""Parses response of an exchange token request. 

Most providers return JSON but some (e.g. Facebook) return a
url-encoded string.

http://codereview.appspot.com/6352088/diff/18001/oauth2client/client.py#newco...
oauth2client/client.py:894: content as a dictionary object. Note that the dict
could be empty,
Content

[alexv, 2012-07-11 14:58:52]

http://codereview.appspot.com/6352088/diff/18001/oauth2client/client.py
File oauth2client/client.py (right):

http://codereview.appspot.com/6352088/diff/18001/oauth2client/client.py#newco...
oauth2client/client.py:885: """
On 2012/07/11 14:38:21, jcgregorio_google wrote:
> Reformat doc string to look like:
> 
> """Parses response of an exchange token request. 
> 
> Most providers return JSON but some (e.g. Facebook) return a
> url-encoded string.

Done.

http://codereview.appspot.com/6352088/diff/18001/oauth2client/client.py#newco...
oauth2client/client.py:894: content as a dictionary object. Note that the dict
could be empty,
On 2012/07/11 14:38:21, jcgregorio_google wrote:
> Content

Done.

[jcgregorio_google, 2012-07-11 15:07:08]

LGTM

Committed at
http://code.google.com/p/google-api-python-client/source/detail?r=1116dcf0085...

On 2012/07/11 14:58:52, crhyme wrote:
> http://codereview.appspot.com/6352088/diff/18001/oauth2client/client.py
> File oauth2client/client.py (right):
> 
>
http://codereview.appspot.com/6352088/diff/18001/oauth2client/client.py#newco...
> oauth2client/client.py:885: """
> On 2012/07/11 14:38:21, jcgregorio_google wrote:
> > Reformat doc string to look like:
> > 
> > """Parses response of an exchange token request. 
> > 
> > Most providers return JSON but some (e.g. Facebook) return a
> > url-encoded string.
> 
> Done.
> 
>
http://codereview.appspot.com/6352088/diff/18001/oauth2client/client.py#newco...
> oauth2client/client.py:894: content as a dictionary object. Note that the dict
> could be empty,
> On 2012/07/11 14:38:21, jcgregorio_google wrote:
> > Content
> 
> Done.