Issue 6352071: SkLightingImageFilter cleanup

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6352071: SkLightingImageFilter cleanup (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years ago by Stephen White

Modified:
12 years ago

Reviewers:
reed, reed1, TomH

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Description

Made the light color part of the light, rather than the filter, so computation is localized. Changed a couple of non-const refs in the image filter creation API const refs. Changed "const SkColor&" to "SkColor", since it's just a uint32_t anyway.

Patch Set 1 #

Created: 12 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+79 lines, -76 lines)			Patch
		include/effects/SkLightingImageFilter.h	View		1 chunk	+9 lines, -12 lines	0 comments	Download
		src/effects/SkLightingImageFilter.cpp	View		16 chunks	+70 lines, -64 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

reed1

lgtm We should write some benchmarks for each of our imagefilters, so we can easily ...

12 years ago (2012-07-09 13:52:27 UTC) #2

Landed in r4466; closing.

Expand All Messages | Collapse All Messages