Issue 6352056: code review 6352056: go.crypto/ssh: add ClientAuthAgent

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6352056: code review 6352056: go.crypto/ssh: add ClientAuthAgent

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 9 months ago by gburd

Modified:
11 years, 9 months ago

Reviewers:

CC:
golang-dev, agl1

Visibility:
Public.

Description

go.crypto/ssh: add ClientAuthAgent ClientAuthAgent adapts a *AgentClient to a ClientAuth.

Patch Set 2 : diff -r 7369c049acc1 https://code.google.com/p/go.crypto/ #

Patch Set 3 : diff -r 7369c049acc1 https://code.google.com/p/go.crypto/ #

Total comments: 1

Patch Set 4 : diff -r 7369c049acc1 https://code.google.com/p/go.crypto/ #

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+49 lines, -0 lines)			Patch
	M	ssh/client_auth.go	View	1 2 3	2 chunks	+49 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

gburd

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go.crypto/

11 years, 9 months ago (2012-06-29 16:27:51 UTC) #1

agl1

http://codereview.appspot.com/6352056/diff/4001/ssh/client_auth.go File ssh/client_auth.go (right): http://codereview.appspot.com/6352056/diff/4001/ssh/client_auth.go#newcode340 ssh/client_auth.go:340: kr.keys, err = kr.agent.RequestIdentities() This if, any most of ...

11 years, 9 months ago (2012-06-29 16:31:56 UTC) #2

gburd

Hello golang-dev@googlegroups.com, agl@golang.org (cc: golang-dev@googlegroups.com), Please take another look.

11 years, 9 months ago (2012-06-29 16:50:57 UTC) #3

agl1

11 years, 9 months ago (2012-06-29 17:05:59 UTC) #4

*** Submitted as
http://code.google.com/p/go/source/detail?r=942ebd6029e7&repo=crypto ***

go.crypto/ssh: add ClientAuthAgent

ClientAuthAgent adapts a *AgentClient to a ClientAuth.

R=golang-dev, agl
CC=golang-dev
http://codereview.appspot.com/6352056

Committer: Adam Langley <agl@golang.org>

Expand All Messages | Collapse All Messages