Issue 6351112: Bring SkNEW to lighting effects

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6351112: Bring SkNEW to lighting effects (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years ago by TomH

Modified:
13 years ago

Reviewers:
Stephen White, senorblanco

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

While digging into crazy Android bugs, I noticed lighting effects were using naked 'new' calls. This is nominally bad.

Created: 13 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -19 lines)			Patch
	M	src/effects/SkLightingImageFilter.cpp	View		8 chunks	+20 lines, -19 lines	0 comments	Download

Total messages: 3

Stephen White

LGTM. BTW, there's nothing in the skia style guide about SkNEW and SkNEW_ARGS; perhaps someone ...

13 years ago (2012-07-20 14:14:36 UTC) #2

Committed as r4689, and style guide updated.