http://codereview.appspot.com/6350059/diff/1/src/core/SkPictureRecord.cpp File src/core/SkPictureRecord.cpp (left): http://codereview.appspot.com/6350059/diff/1/src/core/SkPictureRecord.cpp#oldcode191 src/core/SkPictureRecord.cpp:191: addInt(ClipParams_pack(op, doAA)); small, but I think I prefer the ...
On 2012/06/29 20:46:47, reed1 wrote:
http://codereview.appspot.com/6350059/diff/1/src/core/SkPictureRecord.cpp#old...
> src/core/SkPictureRecord.cpp:191: addInt(ClipParams_pack(op, doAA));
> small, but I think I prefer the old name, so it doesn't look like another
> "add.." function, all of which add something to the opcode stream.
>
Technically speaking this function is adding something to the opcode stream, but
I get what you mean. The old name confused me when I first read this code, so I
would like to give it a clearer name. In the latest patch set, I named it
recordRestoreOffsetPlaceholder. What do you think?
Issue 6350059: Refactoring code in SkPictureRecord that touches fRestoreOffsetStack
(Closed)
Created 13 years ago by junov1
Modified 13 years ago
Reviewers: reed1
Base URL: http://skia.googlecode.com/svn/trunk/
Comments: 2