Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1283)

Issue 6348104: Add support for additionalProperties when printing schema'd objects. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 1 month ago by jcgregorio_google
Modified:
12 years, 1 month ago
Reviewers:
aiuto
CC:
google-api-python-client_googlegroups.com
Visibility:
Public.

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -4 lines) Patch
M apiclient/schema.py View 1 chunk +7 lines, -3 lines 1 comment Download
M tests/data/zoo.json View 1 chunk +20 lines, -0 lines 0 comments Download
M tests/test_schema.py View 2 chunks +22 lines, -1 line 0 comments Download

Messages

Total messages: 3
jcgregorio_google
12 years, 1 month ago (2012-07-12 17:52:59 UTC) #1
aiuto
lgtm - modulo the discussion about having props and additionalProps, which is admittedly strange. http://codereview.appspot.com/6348104/diff/1/apiclient/schema.py ...
12 years, 1 month ago (2012-07-12 19:21:32 UTC) #2
jcgregorio_google
12 years, 1 month ago (2012-07-12 20:05:34 UTC) #3
Committed at
http://code.google.com/p/google-api-python-client/source/detail?r=c008a2e3c1c...

On 2012/07/12 19:21:32, aiuto wrote:
> lgtm - modulo the discussion about having props and additionalProps, which is
> admittedly strange.
> 
> http://codereview.appspot.com/6348104/diff/1/apiclient/schema.py
> File apiclient/schema.py (right):
> 
> http://codereview.appspot.com/6348104/diff/1/apiclient/schema.py#newcode251
> apiclient/schema.py:251: elif 'additionalProperties' in schema:
> It's possible, but very rare, for a schema to have both properties AND
> additionalProperties. The old buzz stuff did that. The way I proposed
supporting
> that for Java was to generate the class with the properties, but change the
> superclass from GenericJson to  Map<string, type defined by
> additionalProperties>. 
> 
> For Python it probably matters less, but perhaps it does for documentation.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b