lgtm - modulo the discussion about having props and additionalProps, which is admittedly strange. http://codereview.appspot.com/6348104/diff/1/apiclient/schema.py ...
12 years, 1 month ago
(2012-07-12 19:21:32 UTC)
#2
lgtm - modulo the discussion about having props and additionalProps, which is
admittedly strange.
http://codereview.appspot.com/6348104/diff/1/apiclient/schema.py
File apiclient/schema.py (right):
http://codereview.appspot.com/6348104/diff/1/apiclient/schema.py#newcode251
apiclient/schema.py:251: elif 'additionalProperties' in schema:
It's possible, but very rare, for a schema to have both properties AND
additionalProperties. The old buzz stuff did that. The way I proposed supporting
that for Java was to generate the class with the properties, but change the
superclass from GenericJson to Map<string, type defined by
additionalProperties>.
For Python it probably matters less, but perhaps it does for documentation.
Committed at http://code.google.com/p/google-api-python-client/source/detail?r=c008a2e3c1c513bc2927d445f89cc8df4624bb5b On 2012/07/12 19:21:32, aiuto wrote: > lgtm - modulo the discussion about ...
12 years, 1 month ago
(2012-07-12 20:05:34 UTC)
#3
Committed at
http://code.google.com/p/google-api-python-client/source/detail?r=c008a2e3c1c...
On 2012/07/12 19:21:32, aiuto wrote:
> lgtm - modulo the discussion about having props and additionalProps, which is
> admittedly strange.
>
> http://codereview.appspot.com/6348104/diff/1/apiclient/schema.py
> File apiclient/schema.py (right):
>
> http://codereview.appspot.com/6348104/diff/1/apiclient/schema.py#newcode251
> apiclient/schema.py:251: elif 'additionalProperties' in schema:
> It's possible, but very rare, for a schema to have both properties AND
> additionalProperties. The old buzz stuff did that. The way I proposed
supporting
> that for Java was to generate the class with the properties, but change the
> superclass from GenericJson to Map<string, type defined by
> additionalProperties>.
>
> For Python it probably matters less, but perhaps it does for documentation.
Issue 6348104: Add support for additionalProperties when printing schema'd objects.
(Closed)
Created 12 years, 1 month ago by jcgregorio_google
Modified 12 years, 1 month ago
Reviewers: aiuto
Base URL:
Comments: 1