Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(9)

Issue 6348043: Altered SkInstCnt to print out atexit (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 2 months ago by robertphillips
Modified:
12 years, 2 months ago
Reviewers:
bsalomon
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

This doesn't buy us much in terms of eliminating "leaks" but does remove the ugliness in gmmain.cpp BEFORE Leaked SkRefCnt: 267 Leaked SkFlattenable: 233 Leaked SkWeakRefCnt: 1 Leaked SkTypeface: 1 Leaked GrFontScaler: 4 Leaked GrKey: 4 Leaked SkPDFObject: 22 Leaked SkPDFDict: 2 Leaked SkPDFArray: 2 Leaked SkPDFName: 8 Leaked SkPDFInt: 10 Leaked SkStream: 1 Leaked SkMemoryStream: 1 Leaked SkData: 2 AFTER Leaked SkRefCnt: 266 Leaked SkFlattenable: 232 Leaked SkWeakRefCnt: 1 Leaked SkTypeface: 1 Leaked GrFontScaler: 4 Leaked GrKey: 4 Leaked SkPDFObject: 22 Leaked SkPDFDict: 2 Leaked SkPDFArray: 2 Leaked SkPDFName: 8 Leaked SkPDFInt: 10 Leaked SkStream: 1 Leaked SkMemoryStream: 1 Leaked SkData: 2

Patch Set 1 #

Patch Set 2 : Updated for changes from r4376 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -6 lines) Patch
M gm/gmmain.cpp View 1 1 chunk +0 lines, -5 lines 0 comments Download
M include/core/SkInstCnt.h View 1 2 chunks +9 lines, -1 line 0 comments Download

Messages

Total messages: 3
robertphillips
12 years, 2 months ago (2012-06-26 21:57:47 UTC) #1
bsalomon
Awesome! LGTM.
12 years, 2 months ago (2012-06-26 22:04:22 UTC) #2
robertphillips
12 years, 2 months ago (2012-06-27 19:52:35 UTC) #3
committed as r4377
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b