|
|
Created:
12 years, 9 months ago by Trevor Daniels Modified:
12 years, 8 months ago CC:
lilypond-user_gnu.org Base URL:
http://git.savannah.gnu.org/gitweb/?p=lilypond.git/trunk/ Visibility:
Public. |
DescriptionDoc: document \on-the-fly (2579)
- explain syntax
- list provided procedures
(Thanks to Eluze for the suggestion)
Patch Set 1 #
Total comments: 2
Patch Set 2 : Added on-page #
Total comments: 2
MessagesTotal messages: 12
A patch is up for review for issue 2579 to document the use of \on-the-fly. (Uploaded, after a struggle, via git-cl on Windows :) Trevor
Sign in to reply to this message.
LGTM http://codereview.appspot.com/6347062/diff/1/Documentation/notation/input.itely File Documentation/notation/input.itely (right): http://codereview.appspot.com/6347062/diff/1/Documentation/notation/input.ite... Documentation/notation/input.itely:1008: @quotation IIRC @multitable is already indented, so I suggest removing the @quotation
Sign in to reply to this message.
<graham@percival-music.ca> wrote Wednesday, July 04, 2012 5:22 PM > http://codereview.appspot.com/6347062/diff/1/Documentation/notation/input.ite... > Documentation/notation/input.itely:1008: @quotation > IIRC @multitable is already indented, so I suggest removing the > @quotation @multitable is not indented here without @quotation. Granted I'm using a very old version of texi2html, but AFAIK this form of @multitable is not indented without @quotation. Maybe a different form of @multitable is indented? For example, you can give the impression of indentation by adding a column at the beginning and leaving it blank. Anyway, it looks better indented, so I'll leave it as it is unless you come back saying you'd definitely like it changed. Trevor
Sign in to reply to this message.
On Wed, Jul 04, 2012 at 09:08:14PM +0100, Trevor Daniels wrote: > > @multitable is not indented here without @quotation. huh, I just checked Documentation/pitches.itexi, and apparently we always use @quotation in conjunction with @multitable. I think that's sub-optimal (if we want multitable to be indented, then the css should be adjusted accordingly and the texinfo source should just use @multitable), but that's clearly how we're doing it at the moment, so there's every reason to continue doing so. - Graham
Sign in to reply to this message.
Omitted to add -devel to Reviewers when I uploaded this patch. Trevor
Sign in to reply to this message.
http://codereview.appspot.com/6347062/diff/1/Documentation/notation/input.itely File Documentation/notation/input.itely (right): http://codereview.appspot.com/6347062/diff/1/Documentation/notation/input.ite... Documentation/notation/input.itely:1018: @item not-first-page @tab not first page in the book? Please add the newly implemented on-page-feature. Perhaps: @item (on-page nmbr) @tab print on page specified by nmbr? Feel free to improve my bad english. -Harm
Sign in to reply to this message.
On 2012/07/05 12:48:32, thomasmorley65 wrote: > Please add the newly implemented on-page-feature. Done. I changed the description to fit better with the column heading of the table.
Sign in to reply to this message.
http://codereview.appspot.com/6347062/diff/1002/Documentation/notation/input.... File Documentation/notation/input.itely (right): http://codereview.appspot.com/6347062/diff/1002/Documentation/notation/input.... Documentation/notation/input.itely:1017: @item (on-page nmbr) @tab is page number = nmbr? whoops - should be 'does', not 'is'. I'll change before committing.
Sign in to reply to this message.
http://codereview.appspot.com/6347062/diff/1002/Documentation/notation/input.... File Documentation/notation/input.itely (right): http://codereview.appspot.com/6347062/diff/1002/Documentation/notation/input.... Documentation/notation/input.itely:1017: @item (on-page nmbr) @tab is page number = nmbr? On 2012/07/06 07:31:08, Trevor Daniels wrote: > whoops - should be 'does', not 'is'. I'll change before > committing. Uh what? It is more correct as it is. Even if you choose to interpret "page number = nmbr" not as a mathematical state and read it aloud symbol by symbol, "Does page number equals nmbr?" is not grammatical either. If you care about spoken grammar, you need to ditch any verb. Otherwise "is" is just fine.
Sign in to reply to this message.
On 2012/07/06 07:38:05, dak wrote: Yes, it's best to drop the verb. That is more consistent with the rest of the table. But we are nitpicking here, aren't we :) Done.
Sign in to reply to this message.
LGTM
Sign in to reply to this message.
|