Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(32)

Issue 6347043: Text context mess cleanup attempt + GMs (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 3 months ago by TomH
Modified:
12 years, 2 months ago
Reviewers:
bsalomon
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Patch Set 1 #

Patch Set 2 : Pay no attention to patch set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -13 lines) Patch
M gm/gradtext.cpp View 1 3 chunks +75 lines, -1 line 1 comment Download
M src/gpu/GrContext.cpp View 1 1 chunk +1 line, -2 lines 0 comments Download
M src/gpu/GrTextContext.cpp View 1 4 chunks +15 lines, -10 lines 0 comments Download

Messages

Total messages: 5
TomH
12 years, 2 months ago (2012-07-10 21:21:45 UTC) #1
bsalomon
On 2012/07/10 21:21:45, TomH wrote: LGTM. We'll prolly want to watch the bench graphs after ...
12 years, 2 months ago (2012-07-10 21:30:09 UTC) #2
bsalomon
I forgot to publish this comment before http://codereview.appspot.com/6347043/diff/2001/gm/gradtext.cpp File gm/gradtext.cpp (right): http://codereview.appspot.com/6347043/diff/2001/gm/gradtext.cpp#newcode41 gm/gradtext.cpp:41: class CGM ...
12 years, 2 months ago (2012-07-11 12:39:55 UTC) #3
TomH
On 2012/07/11 12:39:55, bsalomon wrote: > I forgot to publish this comment before > > ...
12 years, 2 months ago (2012-07-11 13:42:27 UTC) #4
TomH
12 years, 2 months ago (2012-07-11 14:41:34 UTC) #5
Closed with r4531.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b