Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(304)

Issue 6346056: code review 6346056: cmd/dist: Make verbose messages print to stderr (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 10 months ago by peted
Modified:
10 years, 9 months ago
Reviewers:
brainman, rsc
CC:
golang-dev, brainman
Visibility:
Public.

Description

cmd/dist: Make verbose messages print to stderr Made the following changes: - Export errprintf() from all three OS-specific modules - Added errprintf() to a.h - Moved errprintf() in windows.c under xprintf(), since they are so similar - Replaced all instances of xprintf() with errprintf() where a vflag check is done Fixes issue 3788.

Patch Set 1 #

Patch Set 2 : diff -r 4343da022009 https://code.google.com/p/go #

Patch Set 3 : diff -r 4343da022009 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -33 lines) Patch
M src/cmd/dist/a.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/cmd/dist/build.c View 1 6 chunks +7 lines, -7 lines 0 comments Download
M src/cmd/dist/plan9.c View 1 4 chunks +14 lines, -3 lines 0 comments Download
M src/cmd/dist/unix.c View 1 4 chunks +15 lines, -4 lines 0 comments Download
M src/cmd/dist/windows.c View 1 5 chunks +19 lines, -19 lines 0 comments Download

Messages

Total messages: 5
peted
Hello golang-dev@googlegroups.com (cc: alex.brainman@gmail.com), I'd like you to review this change to https://code.google.com/p/go
11 years, 10 months ago (2012-07-01 15:05:49 UTC) #1
brainman
LGTM Thank you. Do not need long CL descriptions. Your code changes speak for themselves. ...
11 years, 9 months ago (2012-07-06 04:59:54 UTC) #2
brainman
*** Submitted as http://code.google.com/p/go/source/detail?r=080799c3785f *** cmd/dist: Make verbose messages print to stderr Made the following ...
11 years, 9 months ago (2012-07-06 05:00:34 UTC) #3
rsc
LGTM
11 years, 9 months ago (2012-07-30 01:27:13 UTC) #4
remyoudompheng
10 years, 9 months ago (2013-07-20 20:11:39 UTC) #5
R=close
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b