I want to move the generation of the final shader strings into GrGLShaderBuilder (as part ...
12 years, 2 months ago
(2012-07-11 13:36:43 UTC)
#1
I want to move the generation of the final shader strings into
GrGLShaderBuilder (as part of uniform manager change). I wanted a ShaderType
enum for this purpose and thought it should then also encompass the variable
lifetime rather than having two very similar enums.
I threw in some other minor changes like promotion to 100 col lines.
Everything but the last is a nit. http://codereview.appspot.com/6344103/diff/2001/src/gpu/gl/GrGLProgram.cpp File src/gpu/gl/GrGLProgram.cpp (right): http://codereview.appspot.com/6344103/diff/2001/src/gpu/gl/GrGLProgram.cpp#newcode1222 src/gpu/gl/GrGLProgram.cpp:1222: segments->addUniform(GrGLShaderBuilder::kFragment_ShaderType, If ...
12 years, 2 months ago
(2012-07-11 14:32:31 UTC)
#2
LGTM http://codereview.appspot.com/6344103/diff/3007/src/gpu/gl/GrGLShaderBuilder.h File src/gpu/gl/GrGLShaderBuilder.h (right): http://codereview.appspot.com/6344103/diff/3007/src/gpu/gl/GrGLShaderBuilder.h#newcode18 src/gpu/gl/GrGLShaderBuilder.h:18: Containts all the incremental state of a shader ...
12 years, 2 months ago
(2012-07-11 14:59:00 UTC)
#4
Issue 6344103: VariableVisibility -> ShaderType
(Closed)
Created 12 years, 2 months ago by bsalomon
Modified 12 years, 2 months ago
Reviewers: TomH
Base URL: http://skia.googlecode.com/svn/trunk/
Comments: 10