ProfilingView should add/remove listeners on demand

ProfilingView should add/remove listeners on demand

BUG=61

Committed: https://code.google.com/p/trace-viewer/source/detail?r=88

[nduca, 2012-07-13 09:15:25]

Previously, the ProfilingView would register listeners on the tracing controller
the second the controller was bound to the view. This was convenient, but has
the bad side effect of exposing all operations on the global tracing controller
to the ProfilingView.

For good reasons, Russ' automation code wants to interact directly with the
tracing controller, without triggering any UI-related activity. Without these
changes, as Russ interacts with tracing controller, the resulting recording is
automatically pulled into the ProfilingView.

With these changes, the recording dialog will be shown, but the profiling view
will not be affected. This allows Russ to create an "offscreen" timeline model
with the recorded data and interact with it without concern about how the UI
stores it.

To do this change, I had to upgrade the profiling_view test a bit so I could try
things out interactively.

[Sam Leffler, 2012-07-13 16:49:03]

The direction looks good but this doesn't seem to work; click Record on a cros
build run on my build host and I get:

[24515:24515:3101559986407:ERROR:CONSOLE(8160)] "Uncaught TypeError: Property
'sendFn_' of object #<Object> is not a function", source:
chrome://tracing/tracing.

Maybe add TEST= to convince me it's my fault :)

[nduca, 2012-07-14 00:29:14]

Hey Sam, the error is in the one place where we can't have test coverage --- the
about_tracing.js.template file. The only way to test edits to this file is by
compiling it into chrome. It sucks, which is why there's so little in that file.

[eatnumber, 2012-07-14 11:50:33]

The following patch fixes it (I'm not sure how to push a fix to a CL that
is not mine)

diff --git a/src/about_tracing.js b/src/about_tracing.js
index 5c5215b..266c0e3 100644
--- a/src/about_tracing.js
+++ b/src/about_tracing.js
@@ -63,7 +63,9 @@ var tracingController;
 var profilingView;  // Made global for debugging purposes only.

 document.addEventListener('DOMContentLoaded', function() {
-  tracingController = new tracing.TracingController();
+  tracingController = new tracing.TracingController(function() {
+    return chrome.send.apply(chrome, arguments);
+  });

   profilingView = document.body.querySelector('#profiling-view');
   base.ui.decorate(profilingView, tracing.ProfilingView);
diff --git a/src/about_tracing.js.template b/src/about_tracing.js.template
index 4b6e7a2..090bd67 100644
--- a/src/about_tracing.js.template
+++ b/src/about_tracing.js.template
@@ -9,7 +9,9 @@ var tracingController;
 var profilingView;  // Made global for debugging purposes only.

 document.addEventListener('DOMContentLoaded', function() {
-  tracingController = new tracing.TracingController();
+  tracingController = new tracing.TracingController(function() {
+    return chrome.send.apply(chrome, arguments);
+  });

   profilingView = document.body.querySelector('#profiling-view');
   base.ui.decorate(profilingView, tracing.ProfilingView);



On Fri, Jul 13, 2012 at 5:29 PM, <nduca@chromium.org> wrote:

>
> Hey Sam, the error is in the one place where we can't have test coverage
> --- the about_tracing.js.template file. The only way to test edits to
> this file is by compiling it into chrome. It sucks, which is why there's
> so little in that file.
>
>
http://codereview.appspot.com/**6343106/<http://codereview.appspot.com/6343106/>
>

[Sam Leffler, 2012-07-16 19:35:14]

lgtm

[Russ Harmon, 2012-07-16 21:00:44]

lgtm