Added GrContext::AutoClipStack to encapsulate setting\resetting of clip stack

Added GrContext::AutoClipStack to encapsulate setting\resetting of clip stack

[robertphillips, 2012-07-11 20:02:45]

http://codereview.appspot.com/6343097/diff/1/src/gpu/SkGpuDevice.cpp
File src/gpu/SkGpuDevice.cpp (right):

http://codereview.appspot.com/6343097/diff/1/src/gpu/SkGpuDevice.cpp#newcode811
src/gpu/SkGpuDevice.cpp:811: }
Don't know if this is better or worse?

[bsalomon, 2012-07-11 20:29:42]

http://codereview.appspot.com/6343097/diff/1/src/gpu/SkGpuDevice.cpp
File src/gpu/SkGpuDevice.cpp (right):

http://codereview.appspot.com/6343097/diff/1/src/gpu/SkGpuDevice.cpp#newcode811
src/gpu/SkGpuDevice.cpp:811: }
On 2012/07/11 20:02:45, robertphillips wrote:
> Don't know if this is better or worse?


Hmm... seems worse

http://codereview.appspot.com/6343097/diff/1/src/gpu/SkGpuDevice.cpp#newcode1444
src/gpu/SkGpuDevice.cpp:1444: GrContext::AutoClipStack acs(context, rect);
Should we call this AutoClipRect? Or do you think you'll make an alternate cons
that takes a stack or path? Maybe AutoClip?

[robertphillips, 2012-07-11 20:45:37]

http://codereview.appspot.com/6343097/diff/1/src/gpu/SkGpuDevice.cpp
File src/gpu/SkGpuDevice.cpp (right):

http://codereview.appspot.com/6343097/diff/1/src/gpu/SkGpuDevice.cpp#newcode811
src/gpu/SkGpuDevice.cpp:811: }
Reverted to old code

http://codereview.appspot.com/6343097/diff/1/src/gpu/SkGpuDevice.cpp#newcode1444
src/gpu/SkGpuDevice.cpp:1444: GrContext::AutoClipStack acs(context, rect);
Done - went with AutoClip.

[bsalomon, 2012-07-11 20:47:20]

On 2012/07/11 20:45:37, robertphillips wrote:
> http://codereview.appspot.com/6343097/diff/1/src/gpu/SkGpuDevice.cpp
> File src/gpu/SkGpuDevice.cpp (right):
> 
>
http://codereview.appspot.com/6343097/diff/1/src/gpu/SkGpuDevice.cpp#newcode811
> src/gpu/SkGpuDevice.cpp:811: }
> Reverted to old code
> 
>
http://codereview.appspot.com/6343097/diff/1/src/gpu/SkGpuDevice.cpp#newcode1444
> src/gpu/SkGpuDevice.cpp:1444: GrContext::AutoClipStack acs(context, rect);
> Done - went with AutoClip.
LGTM

[robertphillips, 2012-07-11 20:58:15]

committed as r4558