Issue 6343093: Remove GrStringBuilder

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6343093: Remove GrStringBuilder (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 1 month ago by bsalomon

Modified:
12 years, 1 month ago

Reviewers:
Stephen White, TomH

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Patch Set 2 : update #

Total comments: 3

Created: 12 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+106 lines, -126 lines)			Patch
M	gyp/gpu.gyp	View		1 chunk	+0 lines, -1 line	0 comments	Download
D	src/gpu/GrStringBuilder.h	View		1 chunk	+0 lines, -19 lines	0 comments	Download
M	src/gpu/effects/GrConvolutionEffect.cpp	View		3 chunks	+4 lines, -4 lines	0 comments	Download
M	src/gpu/effects/GrGradientEffects.cpp	View		6 chunks	+33 lines, -33 lines	0 comments	Download
M	src/gpu/effects/GrMorphologyEffect.cpp	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/gpu/gl/GrGLProgram.h	View		4 chunks	+4 lines, -4 lines	0 comments	Download
M	src/gpu/gl/GrGLProgram.cpp	View		29 chunks	+37 lines, -37 lines	0 comments	Download
M	src/gpu/gl/GrGLProgramStage.h	View		3 chunks	+3 lines, -3 lines	1 comment	Download
M	src/gpu/gl/GrGLShaderBuilder.h	View	1	2 chunks	+10 lines, -10 lines	2 comments	Download
M	src/gpu/gl/GrGLShaderBuilder.cpp	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	src/gpu/gl/GrGLShaderVar.h	View		7 chunks	+10 lines, -10 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

bsalomon

GrGLProgramStage.h (and headers it includes from src/gpu/gl, recursively) needs to be moved to include/gpu/gl. That ...

12 years, 1 month ago (2012-07-10 17:45:05 UTC) #1

Stephen White

LGTM. w00t! http://codereview.appspot.com/6343093/diff/2001/src/gpu/gl/GrGLShaderBuilder.h File src/gpu/gl/GrGLShaderBuilder.h (right): http://codereview.appspot.com/6343093/diff/2001/src/gpu/gl/GrGLShaderBuilder.h#newcode96 src/gpu/gl/GrGLShaderBuilder.h:96: SkString fHeader; // VS+FS, GLSL version, etc ...

12 years, 1 month ago (2012-07-10 17:48:05 UTC) #2

TomH

LGTM modulo, as Stephen describes them, micronits. http://codereview.appspot.com/6343093/diff/2001/src/gpu/gl/GrGLProgramStage.h File src/gpu/gl/GrGLProgramStage.h (right): http://codereview.appspot.com/6343093/diff/2001/src/gpu/gl/GrGLProgramStage.h#newcode17 src/gpu/gl/GrGLProgramStage.h:17: #include "SkString.h" ...

12 years, 1 month ago (2012-07-10 17:48:43 UTC) #3

Fixed all micronits, landed as 4514.

Expand All Messages | Collapse All Messages