Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1118)

Issue 6343071: code review 6343071: runtime: move panic/defer/recover-related stuff to a se... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 9 months ago by dvyukov
Modified:
11 years, 9 months ago
Reviewers:
CC:
golang-dev, dfc, r
Visibility:
Public.

Description

runtime: move panic/defer/recover-related stuff to a separate file Move panic/defer/recover-related stuff from proc.c/runtime.c to a new file panic.c. No semantic changes. proc.c is 1800+ LOC and is a bit difficult to work with.

Patch Set 1 #

Patch Set 2 : diff -r 4a9c9c802565 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 4a9c9c802565 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 4a9c9c802565 https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r 4a9c9c802565 https://go.googlecode.com/hg/ #

Total comments: 2

Patch Set 6 : diff -r 4a9c9c802565 https://go.googlecode.com/hg/ #

Total comments: 1

Patch Set 7 : diff -r 21130d62eeb0 https://go.googlecode.com/hg/ #

Patch Set 8 : diff -r 21130d62eeb0 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+419 lines, -414 lines) Patch
A src/pkg/runtime/panic.c View 1 2 3 4 5 6 1 chunk +392 lines, -0 lines 0 comments Download
M src/pkg/runtime/proc.c View 1 2 5 chunks +1 line, -313 lines 0 comments Download
M src/pkg/runtime/runtime.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/pkg/runtime/runtime.c View 1 2 3 3 chunks +25 lines, -101 lines 0 comments Download

Messages

Total messages: 6
dvyukov
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
11 years, 9 months ago (2012-07-03 11:18:31 UTC) #1
dfc
Looks pretty good. http://codereview.appspot.com/6343071/diff/10001/src/pkg/runtime/panic.c File src/pkg/runtime/panic.c (right): http://codereview.appspot.com/6343071/diff/10001/src/pkg/runtime/panic.c#newcode9 src/pkg/runtime/panic.c:9: // Panic/defer/recover-related stuff. nit: panic/defer/recover related ...
11 years, 9 months ago (2012-07-03 11:28:13 UTC) #2
dvyukov
Thanks. PTAL. http://codereview.appspot.com/6343071/diff/10001/src/pkg/runtime/panic.c File src/pkg/runtime/panic.c (right): http://codereview.appspot.com/6343071/diff/10001/src/pkg/runtime/panic.c#newcode9 src/pkg/runtime/panic.c:9: // Panic/defer/recover-related stuff. On 2012/07/03 11:28:13, dfc ...
11 years, 9 months ago (2012-07-03 11:30:09 UTC) #3
r
LGTM http://codereview.appspot.com/6343071/diff/13001/src/pkg/runtime/panic.c File src/pkg/runtime/panic.c (right): http://codereview.appspot.com/6343071/diff/13001/src/pkg/runtime/panic.c#newcode9 src/pkg/runtime/panic.c:9: // panic/defer/recover related stuff. ha ha. should be: ...
11 years, 9 months ago (2012-07-03 14:39:05 UTC) #4
dvyukov
On 2012/07/03 14:39:05, r wrote: > LGTM > > http://codereview.appspot.com/6343071/diff/13001/src/pkg/runtime/panic.c > File src/pkg/runtime/panic.c (right): > ...
11 years, 9 months ago (2012-07-04 10:49:48 UTC) #5
dvyukov
11 years, 9 months ago (2012-07-04 10:52:58 UTC) #6
*** Submitted as http://code.google.com/p/go/source/detail?r=50000b87157d ***

runtime: move panic/defer/recover-related stuff to a separate file
Move panic/defer/recover-related stuff from proc.c/runtime.c to a new file
panic.c.
No semantic changes.
proc.c is 1800+ LOC and is a bit difficult to work with.

R=golang-dev, dave, r
CC=golang-dev
http://codereview.appspot.com/6343071
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b