Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(35)

Issue 6343055: Clean fonts and docs makefiles, trying to fix 'make -j' race conditions (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 10 months ago by John Mandereau
Modified:
11 years, 8 months ago
Reviewers:
Graham Percival
CC:
lilypond-devel_gnu.org
Base URL:
http://git.savannah.gnu.org/gitweb/?p=lilypond.git/trunk/
Visibility:
Public.

Description

Clean fonts and docs makefiles, trying to fix 'make -j' race conditions On my machine (GNU/Linux Fedora 17 x86_64 on an Intel Core 2 Duo), "make -j3 all" repeatedly calls fontforge before needed .pfb files are generated and makeinfo/extract_texi_filenames/texi2omf before .texi file has been generated/copied. Fix this by using order prerequisites and adding targets to WWW-1 (first stage of doc build); order (rather than ordinary) prerequisites avoid having always outdated targets, which would trigger compilation at install. Remove a rule for Info manual that is no longer needed and which might short-circuit .dep file generation. mf/GNUmakefile: also factorize prerequisites in fonts using a macro.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -110 lines) Patch
M Documentation/GNUmakefile View 1 chunk +1 line, -1 line 0 comments Download
M make/doc-i18n-root-rules.make View 1 chunk +1 line, -1 line 0 comments Download
M make/doc-i18n-root-targets.make View 1 chunk +2 lines, -2 lines 0 comments Download
M make/doc-i18n-root-vars.make View 1 chunk +1 line, -0 lines 0 comments Download
M make/ly-rules.make View 1 chunk +2 lines, -2 lines 0 comments Download
M mf/GNUmakefile View 10 chunks +62 lines, -90 lines 0 comments Download
M stepmake/stepmake/metafont-rules.make View 1 chunk +2 lines, -2 lines 0 comments Download
M stepmake/stepmake/metafont-targets.make View 1 chunk +1 line, -0 lines 0 comments Download
M stepmake/stepmake/texinfo-rules.make View 2 chunks +8 lines, -11 lines 0 comments Download
M stepmake/stepmake/texinfo-targets.make View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 1
Graham Percival
11 years, 10 months ago (2012-06-29 11:02:23 UTC) #1
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b