Issue 6341052: Make GrInOrderDrawBuffer playback command driven

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6341052: Make GrInOrderDrawBuffer playback command driven (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 1 month ago by bsalomon

Modified:
12 years, 1 month ago

Reviewers:
robertphillips

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Patch Set 2 : fix style #

Created: 12 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+182 lines, -149 lines)			Patch
	M	src/gpu/GrInOrderDrawBuffer.h	View	1	6 chunks	+25 lines, -8 lines	0 comments	Download
	M	src/gpu/GrInOrderDrawBuffer.cpp	View	1	13 chunks	+157 lines, -141 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

robertphillips

LGTM w/ one possible nit http://codereview.appspot.com/6341052/diff/1/src/gpu/GrInOrderDrawBuffer.cpp File src/gpu/GrInOrderDrawBuffer.cpp (right): http://codereview.appspot.com/6341052/diff/1/src/gpu/GrInOrderDrawBuffer.cpp#newcode530 src/gpu/GrInOrderDrawBuffer.cpp:530: ++currDraw; next line doesn't ...

12 years, 1 month ago (2012-06-25 21:39:15 UTC) #2

Closed with r4356.

Expand All Messages | Collapse All Messages