Issue 6336056: Fix the stencil rules to perfom an rdiff with an inverse path

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6336056: Fix the stencil rules to perfom an rdiff with an inverse path (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 4 months ago by bsalomon

Modified:
12 years, 4 months ago

Reviewers:
robertphillips

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Patch Set 2 : update #

Total comments: 1

Created: 12 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -3 lines)			Patch
	M	src/gpu/GrStencil.cpp	View		3 chunks	+19 lines, -3 lines	1 comment	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

bsalomon

The existing stencil rule doesn't clear the user portion of the stencil buffer. When MSAA ...

12 years, 4 months ago (2012-06-25 17:55:04 UTC) #1

robertphillips

LGTM modulo 1 nit http://codereview.appspot.com/6336056/diff/2001/src/gpu/GrStencil.cpp File src/gpu/GrStencil.cpp (right): http://codereview.appspot.com/6336056/diff/2001/src/gpu/GrStencil.cpp#newcode169 src/gpu/GrStencil.cpp:169: This first sentence seems a ...

12 years, 4 months ago (2012-06-25 18:01:32 UTC) #2

Fixed comment and landed at r4328.

Expand All Messages | Collapse All Messages