code review 6336054: runtime: remove memset/memclr shim

runtime: remove memset/memclr shim

This CL resolves https://codereview.appspot.com/6300043/#msg3
by renaming memset_arm.s to memclr_arm.s and merging the function
of the same name from asm_arm.s.

[dfc, 2012-06-25 11:24:23]

Hello minux.ma@gmail.com, rsc@golang.org (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go

[dfc, 2012-06-25 11:34:06]

No significant performance improvement (or regression)

benchmark                 old ns/op    new ns/op    delta
BenchmarkBinaryTree17   37223327000  36789917000   -1.16%
BenchmarkFannkuch11     34393432000  34399383000   +0.02%
BenchmarkGobDecode        128038000    121444700   -5.15%
BenchmarkGobEncode         59823000     60045160   +0.37%
BenchmarkGzip            5749909000   5538788000   -3.67%
BenchmarkGunzip          1202209000   1202636000   +0.04%
BenchmarkJSONEncode       784747400    808099400   +2.98%
BenchmarkJSONDecode      2767456000   2821563000   +1.96%
BenchmarkMandelbrot200     45529780     45632920   +0.23%
BenchmarkParse             60052480     60308240   +0.43%
BenchmarkRevcomp          143554700    143377700   -0.12%
BenchmarkTemplate        6092438000   5965546000   -2.08%

benchmark                  old MB/s     new MB/s  speedup
BenchmarkGobDecode             5.99         6.32    1.06x
BenchmarkGobEncode            12.83        12.78    1.00x
BenchmarkGzip                  3.37         3.50    1.04x
BenchmarkGunzip               16.14        16.14    1.00x
BenchmarkJSONEncode            2.47         2.40    0.97x
BenchmarkJSONDecode            0.70         0.69    0.99x
BenchmarkParse                 0.96         0.96    1.00x
BenchmarkRevcomp              17.71        17.73    1.00x
BenchmarkTemplate              0.32         0.33    1.03x

[rsc, 2012-06-25 12:43:56]

LGTM after reverting the copyright notice change

http://codereview.appspot.com/6336054/diff/1002/src/pkg/runtime/memclr_arm.s
File src/pkg/runtime/memclr_arm.s (right):

http://codereview.appspot.com/6336054/diff/1002/src/pkg/runtime/memclr_arm.s#...
src/pkg/runtime/memclr_arm.s:1: // Derived from Inferno's libkern/memset-arm.s
(renamed to memclr_arm.s)
Revert this change. This isn't the first change (it already says Portions
Copyright 2009 The Go Authors below), and the current file's name doesn't have
to appear in the file.

[dfc, 2012-06-25 12:54:36]

Thanks for your comments, the diff is now very small.

http://codereview.appspot.com/6336054/diff/1002/src/pkg/runtime/memclr_arm.s
File src/pkg/runtime/memclr_arm.s (right):

http://codereview.appspot.com/6336054/diff/1002/src/pkg/runtime/memclr_arm.s#...
src/pkg/runtime/memclr_arm.s:1: // Derived from Inferno's libkern/memset-arm.s
(renamed to memclr_arm.s)
On 2012/06/25 12:43:56, rsc wrote:
> Revert this change. This isn't the first change (it already says Portions
> Copyright 2009 The Go Authors below), and the current file's name doesn't have
> to appear in the file.

Will do, thanks for the advice.

[dfc, 2012-06-25 12:54:51]

Hello minux.ma@gmail.com, rsc@golang.org (cc: golang-dev@googlegroups.com),

Please take another look.

[dfc, 2012-06-25 13:01:49]

*** Submitted as http://code.google.com/p/go/source/detail?r=4b823a31b17d ***

runtime: remove memset/memclr shim

This CL resolves https://codereview.appspot.com/6300043/#msg3
by renaming memset_arm.s to memclr_arm.s and merging the function
of the same name from asm_arm.s.

R=minux.ma, rsc
CC=golang-dev
http://codereview.appspot.com/6336054