Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3705)

Issue 6329068: Removed cached copy of the GrDebugGLInterface (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 4 months ago by robertphillips
Modified:
12 years, 4 months ago
Reviewers:
reed1
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

The GrDebugGLInterface wasn't being leaked but was being freed post-main. The cached copy was somewhat of a belt-and-suspenders solution since GrContextFactory also caches the GLInterface. BEFORE Leaked SkRefCnt: 270 Leaked SkFlattenable: 233 Leaked SkWeakRefCnt: 3 Leaked SkTypeface: 3 Leaked GrGLInterface: 1 Leaked SkPDFObject: 22 Leaked SkPDFDict: 2 Leaked SkPDFArray: 2 Leaked SkPDFName: 8 Leaked SkPDFInt: 10 Leaked SkStream: 1 Leaked SkMemoryStream: 1 Leaked SkData: 2 Leaked ???: 8 AFTER Leaked SkRefCnt: 269 Leaked SkFlattenable: 233 Leaked SkWeakRefCnt: 3 Leaked SkTypeface: 3 Leaked SkPDFObject: 22 Leaked SkPDFDict: 2 Leaked SkPDFArray: 2 Leaked SkPDFName: 8 Leaked SkPDFInt: 10 Leaked SkStream: 1 Leaked SkMemoryStream: 1 Leaked SkData: 2 Leaked ???: 8

Patch Set 1 #

Total comments: 2

Patch Set 2 : Called SkNEW instead of new #

Unified diffs Side-by-side diffs Delta from patch set Stats (+129 lines, -127 lines) Patch
M src/gpu/gl/debug/GrGLCreateDebugInterface.cpp View 1 3 chunks +129 lines, -127 lines 0 comments Download

Messages

Total messages: 3
robertphillips
One less thing to worry about
12 years, 4 months ago (2012-06-26 19:25:18 UTC) #1
reed1
lgtm http://codereview.appspot.com/6329068/diff/1/src/gpu/gl/debug/GrGLCreateDebugInterface.cpp File src/gpu/gl/debug/GrGLCreateDebugInterface.cpp (left): http://codereview.appspot.com/6329068/diff/1/src/gpu/gl/debug/GrGLCreateDebugInterface.cpp#oldcode1045 src/gpu/gl/debug/GrGLCreateDebugInterface.cpp:1045: return glInterface.get(); nit: SkNEW(...)
12 years, 4 months ago (2012-06-26 19:27:47 UTC) #2
robertphillips
12 years, 4 months ago (2012-06-26 20:20:07 UTC) #3
committed as r4354

http://codereview.appspot.com/6329068/diff/1/src/gpu/gl/debug/GrGLCreateDebug...
File src/gpu/gl/debug/GrGLCreateDebugInterface.cpp (left):

http://codereview.appspot.com/6329068/diff/1/src/gpu/gl/debug/GrGLCreateDebug...
src/gpu/gl/debug/GrGLCreateDebugInterface.cpp:1045: return glInterface.get();
On 2012/06/26 19:27:47, reed1 wrote:
> nit: SkNEW(...)

Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b