Record pixel ref's gen ID in picture

[junov1, 2012-06-21 14:59:09]

Ah, so I suppose this fixes texture cache problem you saw with deferred canvas
rendering?

This is probably not a blocker, but I would still vote for cherry picking this
one into the M21 branch if it has a high impact on perf.

[bsalomon, 2012-06-21 15:21:07]

On 2012/06/21 14:59:09, junov1 wrote:
> Ah, so I suppose this fixes texture cache problem you saw with deferred canvas
> rendering?

Correct. With this change the sw canvas contents are not reuploaded on every
frame.

> 
> This is probably not a blocker, but I would still vote for cherry picking this
> one into the M21 branch if it has a high impact on perf.

I agree. If we don't see any regressions in the canary I think it is a candidate
for merging.

[reed1, 2012-06-21 18:05:05]

lgtm

is the static cast required?

[bsalomon, 2012-06-21 18:13:48]

On 2012/06/21 18:05:05, reed1 wrote:
> lgtm
> 
> is the static cast required?

I put it there to suppress any -Wsign-conversion warnings but maybe we don't
compile with that enabled anywhere.

[reed1, 2012-06-21 18:23:55]

I never see that warning. I do see signed/unsigned comparisons warnings, but not
conversions (afaik)

[bsalomon, 2012-06-21 18:27:27]

On 2012/06/21 18:23:55, reed1 wrote:
> I never see that warning. I do see signed/unsigned comparisons warnings, but
not
> conversions (afaik)

Ok, will remove before checking in.

[bsalomon, 2012-06-21 20:14:39]

Closed with r4289