Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2590)

Issue 63230: Removes the makeRequest post param check.

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 10 months ago by Jinhui Du
Modified:
14 years, 9 months ago
Reviewers:
chabotc, shindig.remailer
Base URL:
http://svn.apache.org/repos/asf/incubator/shindig/trunk/
Visibility:
Public.

Description

1. Removes the makeRequest post param check. We shouldn't check the data posted to the home server of the apps. 2. Uses HTTP put method to update and the post method to create. It only affects MessageHandler. Since all the other handlers(ActivityHandler, InvalidateHandler, PersonHandler, AppDataHandler) either treat the post and the put method as the same or don't support the put method. 3. Adds message.xml for message api debugging. 4. Changes the error message in message handler.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+128 lines, -22 lines) Patch
php/src/gadgets/ProxyBase.php View 2 chunks +2 lines, -17 lines 0 comments Download
php/src/social/service/DataRequestHandler.php View 1 chunk +2 lines, -2 lines 0 comments Download
php/src/social/service/MessagesHandler.php View 3 chunks +3 lines, -3 lines 0 comments Download
php/test/misc/message.xml View 1 chunk +121 lines, -0 lines 0 comments Download

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b