Issue 63214: don't depend on gadgets.oauth.Popup for basic OAuth support

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 63214: don't depend on gadgets.oauth.Popup for basic OAuth support

Can't Edit
Can't Publish+Mail
Start Review

Created:
16 years, 3 months ago by beaton

Modified:
16 years, 3 months ago

Reviewers:
shindig.remailer, etnu00

Base URL:
https://svn.apache.org/repos/asf/incubator/shindig/trunk/

Visibility:
Public.

Patch Set 1 #

Total comments: 3

Created: 16 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+8 lines, -18 lines)			Patch
M	features/src/main/javascript/features/core.io/io.js	View	1 chunk	+3 lines, -6 lines	3 comments	Download
M	features/src/main/javascript/features/oauthpopup/oauthpopup.js	View	1 chunk	+0 lines, -8 lines	0 comments	Download
M	features/src/test/javascript/features/core.io/iotest.js	View	3 chunks	+4 lines, -0 lines	0 comments	Download
M	java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/OAuthCallbackServlet.java	View	1 chunk	+1 line, -4 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

etnu00

http://codereview.appspot.com/63214/diff/1/4 File features/src/main/javascript/features/core.io/io.js (right): http://codereview.appspot.com/63214/diff/1/4#newcode367 Line 367: if (window.oauthReceivedCallbackUrl_) { Why is this being placed ...

16 years, 3 months ago (2009-06-12 23:24:19 UTC) #1

beaton

16 years, 3 months ago (2009-06-12 23:54:52 UTC) #2

http://codereview.appspot.com/63214/diff/1/4
File features/src/main/javascript/features/core.io/io.js (right):

http://codereview.appspot.com/63214/diff/1/4#newcode367
Line 367: if (window.oauthReceivedCallbackUrl_) {
Because I'm trying to make this work automatically even for gadgets that don't
use the popup library.  If we can do that, we don't need to ask gadget authors
to change their gadgets to support 1.0a.

I'm not particular about window vs gadgets vs gadgets.io, the main thing is that
OAuth gadgets today don't actually require gadgets.oauth.Popup in order to work.

The main reason to prefer window over gadgets.io is that osapi.oauth might make
gadgets.io obsolete.

Expand All Messages | Collapse All Messages