Issue 63213: HTTP 400 should not discard OAuth tokens

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 63213: HTTP 400 should not discard OAuth tokens

Can't Edit
Can't Publish+Mail
Start Review

Created:
16 years, 3 months ago by beaton

Modified:
16 years, 3 months ago

Reviewers:
shindig.remailer, etnu00

Base URL:
https://svn.apache.org/repos/asf/incubator/shindig/trunk/

Visibility:
Public.

Patch Set 1 #

Total comments: 1

Created: 16 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+32 lines, -3 lines)			Patch
M	java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth/OAuthRequest.java	View	1 chunk	+2 lines, -3 lines	1 comment	Download
M	java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth/testing/FakeOAuthServiceProvider.java	View	3 chunks	+10 lines, -0 lines	0 comments	Download
M	java/gadgets/src/test/java/org/apache/shindig/gadgets/oauth/OAuthRequestTest.java	View	1 chunk	+20 lines, -0 lines	0 comments	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

etnu00

16 years, 3 months ago (2009-06-12 23:18:18 UTC) #1

http://codereview.appspot.com/63213/diff/1/3
File
java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth/OAuthRequest.java
(right):

http://codereview.appspot.com/63213/diff/1/3#newcode858
Line 858: if (response.getHttpStatusCode() != 401 &&
response.getHttpStatusCode() != 403) {
It would be nice if this used the mnemonic constants on HTTP response so that we
don't have to try to remember what a 401 stands for.

Expand All Messages | Collapse All Messages