Some Linux / 64-bit compile fixes.

Some Linux / 64-bit compile fixes.

[reed, 2009-06-05 08:21:12]

Nice fixes in most places. A few questions...

http://codereview.appspot.com/63189/diff/1/2
File include/views/SkWidgetViews.h (right):

http://codereview.appspot.com/63189/diff/1/2#newcode108
Line 108: protected:
Why do these INHERITED declarations need to be protected, instead of private?

http://codereview.appspot.com/63189/diff/1/4
File samplecode/SampleApp.cpp (right):

http://codereview.appspot.com/63189/diff/1/4#newcode11
Line 11: #include "SkOSWindow_SDL.h"
Why is this include needed? Doesn't this make the .cpp file less portable
between different platforms?

http://codereview.appspot.com/63189/diff/1/10
File xcode/sampleapp_sdl/skia_sdl_main.cpp (right):

http://codereview.appspot.com/63189/diff/1/10#newcode17
Line 17: #include "SkOSWindow_SDL.h"
Same question here as in SampleApp.cpp, why the need to pull in that header
directly?

[deanm, 2009-06-09 12:27:03]

http://codereview.appspot.com/63189/diff/1/2
File include/views/SkWidgetViews.h (right):

http://codereview.appspot.com/63189/diff/1/2#newcode108
Line 108: protected:
On 2009/06/05 08:21:12, reed wrote:
> Why do these INHERITED declarations need to be protected, instead of private?

They were accessed from a subclass somewhere.  I'll check again exactly where.

http://codereview.appspot.com/63189/diff/1/4
File samplecode/SampleApp.cpp (right):

http://codereview.appspot.com/63189/diff/1/4#newcode11
Line 11: #include "SkOSWindow_SDL.h"
I'll double check why I did this.  I agree with what you're saying.

On 2009/06/05 08:21:12, reed wrote:
> Why is this include needed? Doesn't this make the .cpp file less portable
> between different platforms?

http://codereview.appspot.com/63189/diff/1/10
File xcode/sampleapp_sdl/skia_sdl_main.cpp (right):

http://codereview.appspot.com/63189/diff/1/10#newcode17
Line 17: #include "SkOSWindow_SDL.h"
SkOSWindow is used below, and we need the definition.

On 2009/06/05 08:21:12, reed wrote:
> Same question here as in SampleApp.cpp, why the need to pull in that header
> directly?

[deanm, 2009-06-10 13:11:50]

Hey Mike,

You were right, my SK_BUILD_FOR_SDL was getting lost.  Updated.

On 2009/06/09 12:27:03, deanm wrote:
> http://codereview.appspot.com/63189/diff/1/2
> File include/views/SkWidgetViews.h (right):
> 
> http://codereview.appspot.com/63189/diff/1/2#newcode108
> Line 108: protected:
> On 2009/06/05 08:21:12, reed wrote:
> > Why do these INHERITED declarations need to be protected, instead of
private?
> 
> They were accessed from a subclass somewhere.  I'll check again exactly where.
> 
> http://codereview.appspot.com/63189/diff/1/4
> File samplecode/SampleApp.cpp (right):
> 
> http://codereview.appspot.com/63189/diff/1/4#newcode11
> Line 11: #include "SkOSWindow_SDL.h"
> I'll double check why I did this.  I agree with what you're saying.
> 
> On 2009/06/05 08:21:12, reed wrote:
> > Why is this include needed? Doesn't this make the .cpp file less portable
> > between different platforms?
> 
> http://codereview.appspot.com/63189/diff/1/10
> File xcode/sampleapp_sdl/skia_sdl_main.cpp (right):
> 
> http://codereview.appspot.com/63189/diff/1/10#newcode17
> Line 17: #include "SkOSWindow_SDL.h"
> SkOSWindow is used below, and we need the definition.
> 
> On 2009/06/05 08:21:12, reed wrote:
> > Same question here as in SampleApp.cpp, why the need to pull in that header
> > directly?

[reed, 2009-06-10 18:25:33]

LGTM