Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(215)

Issue 63181: Changes to the resizing pipeline. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 10 months ago by fmil
Modified:
14 years, 6 months ago
Reviewers:
louiscryan
CC:
shindig.remailer_gmail.com
Visibility:
Public.

Description

Changes to the resizing pipeline. The resizer now modifies the original HTTP response when resizing is requested, so that the image optimizer uses the resized image as the reference, and not the original image. This allows the resizer to do its work even if the resized image is larger than the original image. A huge input image is left untouched and returned as-is. A request for a huge output image is not honored; but the image is optimized. Some source cleanup to the image rewriter code. o Added annotations to remove warnings for the optimizer. o Removed declared exceptions that are not thrown. o The grammarian strikes again :) o Removed empty @returns

Patch Set 1 #

Patch Set 2 : Corrected the test image dimensions. #

Patch Set 3 : Correct the pixel dimensions of dog.gif #

Patch Set 4 : Fixes the rendering of transparent-background images. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+142 lines, -34 lines) Patch
M java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/image/BMPOptimizer.java View 1 chunk +4 lines, -3 lines 0 comments Download
M java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/image/BaseOptimizer.java View 2 chunks +1 line, -3 lines 0 comments Download
M java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/image/BasicImageRewriter.java View 1 2 3 10 chunks +61 lines, -8 lines 0 comments Download
M java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/image/GIFOptimizer.java View 1 chunk +4 lines, -4 lines 0 comments Download
M java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/image/ImageRewriter.java View 1 chunk +1 line, -1 line 0 comments Download
M java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/image/JPEGOptimizer.java View 3 chunks +5 lines, -2 lines 0 comments Download
M java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/image/PNGOptimizer.java View 4 chunks +6 lines, -3 lines 0 comments Download
M java/gadgets/src/test/java/org/apache/shindig/gadgets/rewrite/image/ImageRewriterTest.java View 1 7 chunks +62 lines, -12 lines 0 comments Download
A java/gadgets/src/test/resources/org/apache/shindig/gadgets/rewrite/image/expand.gif View 0 chunks +-1 lines, --1 lines 0 comments Download
A java/gadgets/src/test/resources/org/apache/shindig/gadgets/rewrite/image/huge.gif View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 2
louiscryan
Looks good
14 years, 10 months ago (2009-06-02 05:19:22 UTC) #1
fmil
14 years, 10 months ago (2009-06-02 20:59:10 UTC) #2
On 2009/06/02 05:19:22, louiscryan wrote:
> Looks good

nb: The GIF images are attached to:
https://issues.apache.org/jira/browse/SHINDIG-1073
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b