Issue 63169: fontconfig: allow fallback for certain magical font names.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 63169: fontconfig: allow fallback for certain magical font names.

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 6 months ago by evan

Modified:
15 years, 6 months ago

Reviewers:
agl

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Description

fontconfig: allow fallback for certain magical font names. See also http://code.google.com/p/chromium/issues/detail?id=10665 .

Patch Set 2 : '' #

Created: 15 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -10 lines)			Patch
	M	src/ports/SkFontHost_fontconfig.cpp	View	1	7 chunks	+22 lines, -10 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

agl

LGTM http://codereview.appspot.com/63169/diff/1/2 File src/ports/SkFontHost_fontconfig.cpp (right): http://codereview.appspot.com/63169/diff/1/2#newcode128 Line 128: family_requested = (const char*)value; nit: space after ...

15 years, 6 months ago (2009-05-29 19:11:44 UTC) #2

evan

http://codereview.appspot.com/63169/diff/1/2 File src/ports/SkFontHost_fontconfig.cpp (right): http://codereview.appspot.com/63169/diff/1/2#newcode128 Line 128: family_requested = (const char*)value; On 2009/05/29 19:11:44, agl ...

15 years, 6 months ago (2009-05-29 20:25:29 UTC) #3

evan

15 years, 6 months ago (2009-06-01 18:49:53 UTC) #4

So what should I do about this?  Should I wait for your refactoring?

Expand All Messages | Collapse All Messages