LGTM, although I'd personally have prepended "musicxml2ly:" to the beginning of the patch subject line. ...
11 years, 10 months ago
(2012-06-22 08:20:56 UTC)
#2
LGTM, although I'd personally have prepended "musicxml2ly:" to the beginning of
the patch subject line. That makes it much more obvious when skimming the git
history (or just available patches to review).
On 2012/06/22 08:20:56, Graham Percival wrote: > LGTM, although I'd personally have prepended "musicxml2ly:" to ...
11 years, 10 months ago
(2012-06-22 08:58:13 UTC)
#3
On 2012/06/22 08:20:56, Graham Percival wrote:
> LGTM, although I'd personally have prepended "musicxml2ly:" to the beginning
of
> the patch subject line. That makes it much more obvious when skimming the git
> history (or just available patches to review).
I just did a git am using his patch, but I'll amend the commit before pushing.
Do we need some license statement from Rodolfo?
--
Julien
So until now cautionary accidentals *were* supported - the problem was just that the software ...
11 years, 10 months ago
(2012-06-22 15:29:13 UTC)
#4
So until now cautionary accidentals *were* supported - the problem was just that
the software that exported mxls didn't mark them appropriately? I.e. they had
parentheses around them, but didn't have appropriate property set?
That's an interesting example of how WYSIWYG sucks.
LGTM
On Fri, Jun 22, 2012 at 08:58:13AM +0000, julien.rioux@gmail.com wrote: > I just did a ...
11 years, 10 months ago
(2012-06-24 01:10:29 UTC)
#5
On Fri, Jun 22, 2012 at 08:58:13AM +0000, julien.rioux@gmail.com wrote:
> I just did a git am using his patch, but I'll amend the commit before
> pushing. Do we need some license statement from Rodolfo?
No; lilypond is not FSF-copyright-assigned, so nothing is needed.
But thanks for checking!
- Graham
Issue 6310065: Treat accidentals parentheses as cautionary
(Closed)
Created 11 years, 10 months ago by Julien Rioux
Modified 11 years, 9 months ago
Reviewers: MikeSol, Graham Percival, janek
Base URL: http://git.savannah.gnu.org/gitweb/?p=lilypond.git/trunk/
Comments: 0