Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(302)

Issue 6310043: cleanup: infinity, get property

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 10 months ago by janek
Modified:
11 years, 10 months ago
Reviewers:
mike, MikeSol, dak
CC:
lilypond-devel_gnu.org
Base URL:
http://git.savannah.gnu.org/gitweb/?p=lilypond.git/trunk/
Visibility:
Public.

Description

cleanup: infinity, get property add a callback for calculating lyric syllables offset

Patch Set 1 #

Total comments: 16

Patch Set 2 : move things to lyric_text #

Patch Set 3 : no code dup. works properly. #

Patch Set 4 : here's how i tried to introduce lyricDefaultAlignment #

Patch Set 5 : inherit from Item #

Patch Set 6 : use grob property instead of context property #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -2 lines) Patch
A lily/lyric-text.cc View 1 2 3 4 5 1 chunk +59 lines, -0 lines 0 comments Download
M scm/define-grob-properties.scm View 1 2 3 4 5 2 chunks +3 lines, -0 lines 0 comments Download
M scm/define-grobs.scm View 1 2 3 4 5 1 chunk +3 lines, -2 lines 1 comment Download

Messages

Total messages: 16
MikeSol
http://codereview.appspot.com/6310043/diff/1/lily/lyric-engraver.cc File lily/lyric-engraver.cc (right): http://codereview.appspot.com/6310043/diff/1/lily/lyric-engraver.cc#newcode42 lily/lyric-engraver.cc:42: TRANSLATOR_DECLARATIONS (Lyric_engraver); You'll need to create a lyric-text.cc and ...
11 years, 10 months ago (2012-06-14 08:19:01 UTC) #1
janek
there are some disputable points, but generally i will send new version (hopefully today). http://codereview.appspot.com/6310043/diff/1/lily/lyric-engraver.cc ...
11 years, 10 months ago (2012-06-14 18:40:02 UTC) #2
janek
Hi, i've moved things around. I've used your suggestion to check if it works at ...
11 years, 10 months ago (2012-06-14 22:33:13 UTC) #3
janek
How do you like this? I've tried to define a new property lyricDefaultAlignment (similar to ...
11 years, 10 months ago (2012-06-15 09:22:28 UTC) #4
dak
On 2012/06/15 09:22:28, janek wrote: > How do you like this? > > I've tried ...
11 years, 10 months ago (2012-06-15 09:42:03 UTC) #5
janek
I forgot that my git-cl is configured to add -devel to cc! This is a ...
11 years, 10 months ago (2012-06-15 14:52:01 UTC) #6
dak
Janek Warchoł <janek.lilypond@gmail.com> writes: > I forgot that my git-cl is configured to add -devel ...
11 years, 10 months ago (2012-06-15 15:04:32 UTC) #7
janek
On Fri, Jun 15, 2012 at 5:04 PM, David Kastrup <dak@gnu.org> wrote: > Janek Warchoł ...
11 years, 10 months ago (2012-06-15 15:52:50 UTC) #8
dak
Janek Warchoł <janek.lilypond@gmail.com> writes: > On Fri, Jun 15, 2012 at 5:04 PM, David Kastrup ...
11 years, 10 months ago (2012-06-15 16:01:01 UTC) #9
janek
On Fri, Jun 15, 2012 at 6:00 PM, David Kastrup <dak@gnu.org> wrote: > What makes ...
11 years, 10 months ago (2012-06-15 16:19:57 UTC) #10
dak
Janek Warchoł <janek.lilypond@gmail.com> writes: > On Fri, Jun 15, 2012 at 6:00 PM, David Kastrup ...
11 years, 10 months ago (2012-06-15 16:48:22 UTC) #11
janek
On Fri, Jun 15, 2012 at 6:48 PM, David Kastrup <dak@gnu.org> wrote: > Janek Warchoł ...
11 years, 10 months ago (2012-06-15 17:41:12 UTC) #12
dak
janek.lilypond@gmail.com writes: > On Fri, Jun 15, 2012 at 6:48 PM, David Kastrup <dak@gnu.org> wrote: ...
11 years, 10 months ago (2012-06-15 19:58:03 UTC) #13
dak
Ok, I am currently somewhat fuzzy. A grob has individual properties, and it has interfaces. ...
11 years, 10 months ago (2012-06-15 20:10:43 UTC) #14
mike_apollinemike.com
On 15 juin 2012, at 22:10, dak@gnu.org wrote: > Ok, I am currently somewhat fuzzy. ...
11 years, 10 months ago (2012-06-15 21:34:13 UTC) #15
janek
11 years, 10 months ago (2012-06-15 21:36:03 UTC) #16
On Fri, Jun 15, 2012 at 9:58 PM,  <dak@gnu.org> wrote:
>>> Good question.  Looking through this and stem, it would seem that
>>> this does not work via inheritance but rather callbacks. So disregard
>>> what I said previously.
>>
>> Should Lyric_text inherit from Item, then?
>
> Apparently not.

ok, it doesn't.

>>> You likely want to use a grob property, in which case you would write
>>> me->get_property (...).
>>
>> Done - works without any problem :)
>> Should i also change lyricMelismaAlignment to be a grob property?
>
> No idea.

i think i'll change it.


On Fri, Jun 15, 2012 at 10:10 PM,  <dak@gnu.org> wrote:
> Ok, I am currently somewhat fuzzy.  A grob has individual properties,
> and it has interfaces.  Interfaces also carry properties.  When a grob
> is created, its properties are initialized from the context and then
> live on independently.
>
> I think that the interface-induced properties initialize from context
> properties unless overriden per grob.  But I really don't have enough of
> a clue of the backend to really tell right now.

Nevertheless many thanks for explanations!  I understand things better now.

cheers,
Janek
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b