Issue 6308057: Unroll convolution fragment shader loop

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6308057: Unroll convolution fragment shader loop (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 6 months ago by TomH

Modified:
12 years, 6 months ago

Reviewers:
bsalomon

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Description

20-30% speedup for Linux on bench -repeat 250 -config GPU -match blur No performance difference on Windows (Quadro FX380). No performance difference on Xoom ?!

Patch Set 2 : Move comment from GLSL to C++ #

Created: 12 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -18 lines)			Patch
	M	src/gpu/effects/GrConvolutionEffect.cpp	View	1	1 chunk	+14 lines, -18 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

bsalomon

http://codereview.appspot.com/6308057/diff/1/src/gpu/effects/GrConvolutionEffect.cpp File src/gpu/effects/GrConvolutionEffect.cpp (right): http://codereview.appspot.com/6308057/diff/1/src/gpu/effects/GrConvolutionEffect.cpp#newcode91 src/gpu/effects/GrConvolutionEffect.cpp:91: code->appendf("\t\t// Unroll loop 0..%d because some drivers don't.\n", Hmm... ...

12 years, 6 months ago (2012-06-08 20:48:20 UTC) #2

Closed with r4218.

Expand All Messages | Collapse All Messages