Issue 6307089: Add table of "bad" fonts, that require extra space (at the bottom) to avoid clipping

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6307089: Add table of "bad" fonts, that require extra space (at the bottom) to avoid clipping

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 3 months ago by reed1

Modified:
12 years, 3 months ago

Reviewers:
bungeman, jshin

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/

Visibility:
Public.

More Reviews

Description

Add table of "bad" fonts, that require extra space (at the bottom) to avoid clipping

Patch Set 2 : #

Total comments: 1

Created: 12 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+45 lines, -1 line)			Patch
	M	trunk/src/ports/SkFontHost_win.cpp	View	1	6 chunks	+45 lines, -1 line	1 comment	Download

Messages

Total messages: 7

Expand All Messages | Collapse All Messages

bungeman

This only happens on TrueType with embedded bitmaps, so it would be nice to notice ...

12 years, 3 months ago (2012-06-13 19:52:49 UTC) #2

bungeman

On 2012/06/13 19:55:30, reed1 wrote: > done and done LGTM

12 years, 3 months ago (2012-06-13 19:57:12 UTC) #4

jshin

Thank you for the fix. I have a comment inline. http://codereview.appspot.com/6307089/diff/5001/trunk/src/ports/SkFontHost_win.cpp File trunk/src/ports/SkFontHost_win.cpp (right): http://codereview.appspot.com/6307089/diff/5001/trunk/src/ports/SkFontHost_win.cpp#newcode33 ...

12 years, 3 months ago (2012-06-13 20:44:18 UTC) #5

reed1

Is it possible to create (or augment) the test html page to use all of ...

12 years, 3 months ago (2012-06-13 21:06:41 UTC) #6

jshin

12 years, 3 months ago (2012-06-13 21:58:11 UTC) #7

On 2012/06/13 21:06:41, reed1 wrote:
> Is it possible to create (or augment) the test html page to use all of these
> fonts. That will make it much easier for me to be sure that I have covered all
> of these font (names).

http://i18nl10n.com/chrome/bug130842.html was changed to allow you to select
each of 4 names in the menu. 

> 
> thanks.

Expand All Messages | Collapse All Messages