Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1159)

Issue 6307069: Adding inline-translation of UI in Blender (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 10 months ago by b.mont29
Modified:
11 years, 1 month ago
Reviewers:
ideasman42
Base URL:
https://svn.blender.org/svnroot/bf-blender/trunk/blender/
Visibility:
Public.

Description

This patch aims to add translation of Blender directly from the User Interface. WARNING: Even though working, it’s currently still work in progress. To do that, it splits the work in two: * A small C operator finds the active button, get from it a bunch of strings (button/rna/enumitem labels and tips, RNA path, RNA context), and gives them to a py op defined in an addon. * A py addon (current diff: http://www.pasteall.org/33552/diff ) reads the right po file, find in it the matching message ids, and popups an UI to edit the translations. Current things I’m not sure about: * It adds a new userpref path to point to /branches i18n dir (and may need another one to mo building tool in future :/ ).

Patch Set 1 #

Total comments: 9

Patch Set 2 : Adressed campbel’s comments. #

Patch Set 3 : Update patch.Together with addon linked on pasteall.org, it’s now rather complete... #

Unified diffs Side-by-side diffs Delta from patch set Stats (+436 lines, -17 lines) Patch
release/scripts/startup/bl_ui/space_userpref.py View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
source/blender/blenfont/BLF_translation.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
source/blender/blenfont/intern/blf_lang.c View 1 2 3 chunks +12 lines, -1 line 0 comments Download
source/blender/editors/include/UI_interface.h View 1 2 1 chunk +28 lines, -0 lines 0 comments Download
source/blender/editors/interface/interface.c View 1 2 1 chunk +128 lines, -0 lines 0 comments Download
source/blender/editors/interface/interface_handlers.c View 1 2 2 chunks +15 lines, -6 lines 0 comments Download
source/blender/editors/interface/interface_ops.c View 1 2 4 chunks +161 lines, -4 lines 0 comments Download
source/blender/editors/interface/interface_regions.c View 1 2 8 chunks +68 lines, -6 lines 0 comments Download
source/blender/makesdna/DNA_userdef_types.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
source/blender/makesrna/RNA_access.h View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
source/blender/makesrna/intern/rna_access.c View 1 2 2 chunks +11 lines, -0 lines 0 comments Download
source/blender/makesrna/intern/rna_userdef.c View 1 2 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 6
mont29
11 years, 10 months ago (2012-06-10 13:28:58 UTC) #1
ideasman42
not full review, looks ok generally - suggestion to change two areas. http://codereview.appspot.com/6307069/diff/1/source/blender/editors/interface/interface.c File source/blender/editors/interface/interface.c ...
11 years, 10 months ago (2012-06-10 13:56:02 UTC) #2
ideasman42
http://codereview.appspot.com/6307069/diff/1/source/blender/editors/interface/interface.c File source/blender/editors/interface/interface.c (right): http://codereview.appspot.com/6307069/diff/1/source/blender/editors/interface/interface.c#newcode3694 source/blender/editors/interface/interface.c:3694: char **uiButGetStrInfo(bContext *C, uiBut *but, int nbr, ...) On ...
11 years, 10 months ago (2012-06-10 14:11:51 UTC) #3
mont29
Adressed campbel’s comments.
11 years, 10 months ago (2012-06-10 20:18:22 UTC) #4
mont29
http://codereview.appspot.com/6307069/diff/1/source/blender/editors/interface/interface.c File source/blender/editors/interface/interface.c (right): http://codereview.appspot.com/6307069/diff/1/source/blender/editors/interface/interface.c#newcode3694 source/blender/editors/interface/interface.c:3694: char **uiButGetStrInfo(bContext *C, uiBut *but, int nbr, ...) On ...
11 years, 10 months ago (2012-06-10 20:20:17 UTC) #5
mont29
11 years, 9 months ago (2012-07-08 20:09:49 UTC) #6
Update patch.Together with addon linked on pasteall.org, it’s now rather
complete...
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b