Update Media Upload to include io.Base and also fix some bugs.

Fixes issue #139 and #123.

http://code.google.com/p/google-api-python-client/issues/detail?id=123
http://code.google.com/p/google-api-python-client/issues/detail?id=139

[Ali Afshar, 2012-06-11 20:27:13]

http://codereview.appspot.com/6307067/diff/7001/apiclient/http.py
File apiclient/http.py (right):

http://codereview.appspot.com/6307067/diff/7001/apiclient/http.py#newcode649
apiclient/http.py:649: self.in_error_state = False
Should this be private _in_error_state ?

[Ali Afshar, 2012-06-11 20:30:23]

LGTM

On 2012/06/11 20:27:13, Ali Afshar wrote:
> http://codereview.appspot.com/6307067/diff/7001/apiclient/http.py
> File apiclient/http.py (right):
> 
> http://codereview.appspot.com/6307067/diff/7001/apiclient/http.py#newcode649
> apiclient/http.py:649: self.in_error_state = False
> Should this be private _in_error_state ?

[aiuto, 2012-06-11 21:25:45]

just a few minor things

http://codereview.appspot.com/6307067/diff/7001/apiclient/http.py
File apiclient/http.py (right):

http://codereview.appspot.com/6307067/diff/7001/apiclient/http.py#newcode592
apiclient/http.py:592: start_headers['X-Upload-Content-Length'] =
str(self.resumable.size())
why not use size here?

http://codereview.appspot.com/6307067/diff/7001/tests/test_discovery.py
File tests/test_discovery.py (right):

http://codereview.appspot.com/6307067/diff/7001/tests/test_discovery.py#newco...
tests/test_discovery.py:590: 'Content-Range': 'bytes */*',
indent?

[jcgregorio_google, 2012-06-12 13:21:17]

http://codereview.appspot.com/6307067/diff/7001/apiclient/http.py
File apiclient/http.py (right):

http://codereview.appspot.com/6307067/diff/7001/apiclient/http.py#newcode592
apiclient/http.py:592: start_headers['X-Upload-Content-Length'] =
str(self.resumable.size())
On 2012/06/11 21:25:45, aiuto wrote:
> why not use size here?

Done.

http://codereview.appspot.com/6307067/diff/7001/apiclient/http.py#newcode649
apiclient/http.py:649: self.in_error_state = False
On 2012/06/11 20:27:13, Ali Afshar wrote:
> Should this be private _in_error_state ?

Done.

http://codereview.appspot.com/6307067/diff/7001/tests/test_discovery.py
File tests/test_discovery.py (right):

http://codereview.appspot.com/6307067/diff/7001/tests/test_discovery.py#newco...
tests/test_discovery.py:590: 'Content-Range': 'bytes */*',
On 2012/06/11 21:25:45, aiuto wrote:
> indent?

Done.

[aiuto, 2012-06-12 13:27:04]

lgtm

[jcgregorio_google, 2012-06-14 18:56:57]

On 2012/06/12 13:27:04, aiuto wrote:
> lgtm

Committed in
http://code.google.com/p/google-api-python-client/source/detail?r=8ae1f255521...