Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1051)

Issue 6306095: fix the following warning for SkColorTable (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 1 month ago by guanqun
Modified:
12 years, 1 month ago
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk
Visibility:
Public.

Description

fix the following warning for SkColorTable ../src/core/SkColorTable.cpp: In copy constructor ‘SkColorTable::SkColorTable(const SkColorTable&)’: ../src/core/SkColorTable.cpp:30:1: warning: base class ‘class SkFlattenable’ should be explicitly initialized in the copy constructor [-Wextra] BUG= TEST=

Patch Set 1 #

Patch Set 2 : add a comment #

Patch Set 3 : comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M src/core/SkColorTable.cpp View 1 2 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 6
guanqun
Please review.
12 years, 1 month ago (2012-06-18 02:38:58 UTC) #1
reed1
Interesting. We have gobs of places where we *don't* explicitly call our inherited constructor (e.g. ...
12 years, 1 month ago (2012-06-18 12:44:09 UTC) #2
guanqun
On 2012/06/18 12:44:09, reed1 wrote: > Perhaps a one-line comment in the code, explaining why ...
12 years, 1 month ago (2012-06-19 01:41:37 UTC) #3
reed1
the comment is perfect. I will help land it.
12 years, 1 month ago (2012-06-19 12:03:17 UTC) #4
reed1
best to create your patch from the trunk/ level... > pwd skia/trunk/ > svn diff ...
12 years, 1 month ago (2012-06-19 15:26:38 UTC) #5
reed1
12 years, 1 month ago (2012-06-19 15:29:08 UTC) #6
landed in rev. 4280.
please close this CL
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b