Fixed two bugs in SW-only clip mask generation

These two only show up when enabling the SW-only path for _all_ the clipping in gm. They could appear in general usage however.

The flushTo recursion bug resulted in a crash while the missing clear when copying results back to the GPU bug resulted in everything outside of the path's bounding box being clipped away.

[robertphillips, 2012-06-14 19:41:35]

http://codereview.appspot.com/6306086/diff/1/src/gpu/GrSoftwarePathRenderer.cpp
File src/gpu/GrSoftwarePathRenderer.cpp (right):

http://codereview.appspot.com/6306086/diff/1/src/gpu/GrSoftwarePathRenderer.c...
src/gpu/GrSoftwarePathRenderer.cpp:219: 
Moved here to toTexture can use it.

[robertphillips, 2012-06-18 14:38:14]

Brian - I believe this addresses the issues we discussed.

[bsalomon, 2012-06-18 15:09:08]

Mostly LGTM. Should we have a default param of NULL or a helper on
target/context that doesn't require a NULL rt param for the common case?

http://codereview.appspot.com/6306086/diff/4001/src/gpu/GrInOrderDrawBuffer.cpp
File src/gpu/GrInOrderDrawBuffer.cpp (right):

http://codereview.appspot.com/6306086/diff/4001/src/gpu/GrInOrderDrawBuffer.c...
src/gpu/GrInOrderDrawBuffer.cpp:464: clr.fRenderTarget = renderTarget;
Don't we need to ref?

[robertphillips, 2012-06-18 16:33:53]

Added default NULL renderTarget parameter to new clear methods. Add ref/unref of
renderTarget in GrInOrderDrawBuffer.

http://codereview.appspot.com/6306086/diff/4001/src/gpu/GrInOrderDrawBuffer.cpp
File src/gpu/GrInOrderDrawBuffer.cpp (right):

http://codereview.appspot.com/6306086/diff/4001/src/gpu/GrInOrderDrawBuffer.c...
src/gpu/GrInOrderDrawBuffer.cpp:464: clr.fRenderTarget = renderTarget;
On 2012/06/18 15:09:08, bsalomon wrote:
> Don't we need to ref?

Done.

[bsalomon, 2012-06-18 17:02:54]

http://codereview.appspot.com/6306086/diff/8001/src/gpu/GrInOrderDrawBuffer.cpp
File src/gpu/GrInOrderDrawBuffer.cpp (right):

http://codereview.appspot.com/6306086/diff/8001/src/gpu/GrInOrderDrawBuffer.c...
src/gpu/GrInOrderDrawBuffer.cpp:465: GrSafeRef(clr.fRenderTarget);
Now don't we also need to unref in the playback?

[robertphillips, 2012-06-18 17:12:35]

http://codereview.appspot.com/6306086/diff/8001/src/gpu/GrInOrderDrawBuffer.cpp
File src/gpu/GrInOrderDrawBuffer.cpp (right):

http://codereview.appspot.com/6306086/diff/8001/src/gpu/GrInOrderDrawBuffer.c...
src/gpu/GrInOrderDrawBuffer.cpp:465: GrSafeRef(clr.fRenderTarget);
I put the unref in the destructor of the Clear struct. I felt that was a more
natural place since playback doesn't actually clear out the pointers.

[bsalomon, 2012-06-18 17:18:25]

LGTM

http://codereview.appspot.com/6306086/diff/8001/src/gpu/GrInOrderDrawBuffer.cpp
File src/gpu/GrInOrderDrawBuffer.cpp (right):

http://codereview.appspot.com/6306086/diff/8001/src/gpu/GrInOrderDrawBuffer.c...
src/gpu/GrInOrderDrawBuffer.cpp:465: GrSafeRef(clr.fRenderTarget);
On 2012/06/18 17:12:35, robertphillips wrote:
> I put the unref in the destructor of the Clear struct. I felt that was a more
> natural place since playback doesn't actually clear out the pointers.
SGTM

[robertphillips, 2012-06-21 20:16:19]

committed as r4290