Issue 6306053: Add SkPath::getVerbs/countVerbs

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6306053: Add SkPath::getVerbs/countVerbs (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 6 months ago by bsalomon

Modified:
12 years, 6 months ago

Reviewers:
reed1

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Total comments: 1

Created: 12 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+162 lines, -10 lines)			Patch
M	include/core/SkPath.h	View		1 chunk	+16 lines, -1 line	0 comments	Download
M	include/core/SkTDArray.h	View	1 2	1 chunk	+17 lines, -0 lines	0 comments	Download
M	src/core/SkGlyphCache.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/core/SkPath.cpp	View	1 2	2 chunks	+12 lines, -4 lines	0 comments	Download
M	tests/PathTest.cpp	View	1 2	13 chunks	+116 lines, -4 lines	0 comments	Download

Total messages: 5

reed1

Perhaps we should augment your tests to also exercise when we pass a buffer. 1. ...

12 years, 6 months ago (2012-06-07 20:14:25 UTC) #2

bsalomon

Added SkTDArray::copyRange(), used in getPoints/getVerbs. Added tests that check the verbs.

12 years, 6 months ago (2012-06-07 21:06:19 UTC) #3

Closed with r4209