Issue 6305118: Move all remaining samples over to client_secrets.json.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6305118: Move all remaining samples over to client_secrets.json. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years ago by jcgregorio_google

Modified:
13 years ago

Reviewers:
rmistry

CC:
google-api-python-client_googlegroups.com

Visibility:
Public.

Patch Set 1 #

Total comments: 2

Created: 13 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+159 lines, -97 lines)			Patch
M	samples/audit/audit.py	View	3 chunks	+39 lines, -32 lines	2 comments	Download
A	samples/audit/client_secrets.json	View	1 chunk	+9 lines, -0 lines	0 comments	Download
A	samples/moderator/client_secrets.json	View	1 chunk	+9 lines, -0 lines	0 comments	Download
M	samples/moderator/moderator.py	View	3 chunks	+49 lines, -34 lines	0 comments	Download
M	samples/storage_serviceaccount_appengine/main.py	View	2 chunks	+11 lines, -11 lines	0 comments	Download
A	samples/urlshortener/client_secrets.json	View	1 chunk	+9 lines, -0 lines	0 comments	Download
M	samples/urlshortener/urlshortener.py	View	4 chunks	+33 lines, -20 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rmistry

LGTM http://codereview.appspot.com/6305118/diff/1/samples/audit/audit.py File samples/audit/audit.py (right): http://codereview.appspot.com/6305118/diff/1/samples/audit/audit.py#newcode47 samples/audit/audit.py:47: from oauth2client.file import Storage Move below oauth2client.client imports ...

13 years ago (2012-06-20 16:03:07 UTC) #2

jcgregorio_google

13 years ago (2012-06-20 16:12:54 UTC) #3

Committed in
http://code.google.com/p/google-api-python-client/source/detail?r=f62d0a48986...

http://codereview.appspot.com/6305118/diff/1/samples/audit/audit.py
File samples/audit/audit.py (right):

http://codereview.appspot.com/6305118/diff/1/samples/audit/audit.py#newcode47
samples/audit/audit.py:47: from oauth2client.file import Storage
On 2012/06/20 16:03:07, rmistry wrote:
> Move below oauth2client.client imports for sorting? and also in other files in
> this CL.

Done.

Expand All Messages | Collapse All Messages