Remove multi-byte character constants.

[bungeman, 2012-06-20 14:59:26]

See also http://codereview.appspot.com/6295095/

For other reasons I have already removed the multi-byte character constants in a
local change set, and this is a good CL to break out from that.

[reed1, 2012-06-20 15:11:25]

Does SkSetFourByteTag('h', 'e', 'a', 'd') not do the trick here?

[bungeman, 2012-06-20 15:25:12]

I'm not against using SkSetFourByteTag, and have used it here. However, I do
still want the TAG0-3 as some(I'm looking at DirectWrite specifically here) have
their own functions / macros which take the individual bytes and create their
own internal representation. At the same time I want the TAG to be appropriately
swizzled for direct comparisons and obviously based off of, and enforce the
existence of, TAG0-3.

[reed1, 2012-06-25 14:11:25]

fontType_Foo is a funny capitalization/naming choice...

LGTM w/ some comments and naming convestions considerations

http://codereview.appspot.com/6305117/diff/1009/src/sfnt/SkOTTableTypes.h
File src/sfnt/SkOTTableTypes.h (left):

http://codereview.appspot.com/6305117/diff/1009/src/sfnt/SkOTTableTypes.h#old...
src/sfnt/SkOTTableTypes.h:34: 
Since this is a BE version of SetFourByteTag, lets add a comment to that effect
here (and why)

[bungeman, 2012-06-26 14:20:26]

Committed revision r4317.