Issue 6305084: Adding API to GrTexture to invalidate cached parameter state

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6305084: Adding API to GrTexture to invalidate cached parameter state (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 6 months ago by junov1

Modified:
12 years, 5 months ago

Reviewers:
bsalomon

CC:
TomH, robertphillips, skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Patch Set 1 #

Total comments: 1

Created: 12 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -0 lines)			Patch
	M	include/gpu/GrTexture.h	View		1 chunk	+6 lines, -0 lines	0 comments	Download
	M	src/gpu/gl/GrGLTexture.h	View		1 chunk	+2 lines, -0 lines	1 comment	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

junov1

This is all I need to implement a simple fix for http://code.google.com/p/chromium/issues/detail?id=130925 in webkit

12 years, 6 months ago (2012-06-11 22:16:50 UTC) #1

bsalomon

Aside from my override nit, LGTM. http://codereview.appspot.com/6305084/diff/1/src/gpu/gl/GrGLTexture.h File src/gpu/gl/GrGLTexture.h (right): http://codereview.appspot.com/6305084/diff/1/src/gpu/gl/GrGLTexture.h#newcode81 src/gpu/gl/GrGLTexture.h:81: virtual void invalidateCachedState() ...

12 years, 6 months ago (2012-06-12 01:35:38 UTC) #2

Fixed with r4234

Expand All Messages | Collapse All Messages