Fix for beaming in Kievan notation

Fix for beaming in Kievan notation

Implementing correct beaming functionality in Kievan notation

Fix for Issue 2492

[aleksandr.andreev, 2012-06-10 23:48:09]

A first attempt at fixing issue 2492.

This fixes the note heads for beamed kievan notes, also getting rid of the
warning messages.

[Keith, 2012-06-11 00:49:42]

looks good to me.

[aleksandr.andreev, 2012-06-11 14:26:01]

On 2012/06/11 00:49:42, Keith wrote:
> looks good to me.

The question I have now is how to affect the position of the beam. It needs to
attach toward the bottom of the "stem" and not at center of the staff.

[aleksandr.andreev, 2012-08-05 00:37:18]

This is definitely not an elegant approach to the problem at all (and it does
not solve the issue of the warning being given out at stem.cc line 128), but
it's the best I can figure out after hacking at the code for a while.

Perhaps reviewers more familiar with LilyPond internals can provide some
comments for improvement.

[dak, 2012-08-07 18:19:14]

http://codereview.appspot.com/6305080/diff/4001/lily/beam.cc
File lily/beam.cc (right):

http://codereview.appspot.com/6305080/diff/4001/lily/beam.cc#newcode636
lily/beam.cc:636: extract_grob_set (stems[0], "note-heads", heads);
This looks like the wrong place to do this calculation.  You overwrite what has
been put into quantized-positions here.  It looks like you should rather move
the calculation to the place where quantized-positions is initialized, or the
behavior will be rather intransparent.

[aleksandr.andreev, 2012-08-08 19:20:35]

On 2012/08/07 18:19:14, dak wrote:
> http://codereview.appspot.com/6305080/diff/4001/lily/beam.cc#newcode636
> lily/beam.cc:636: extract_grob_set (stems[0], "note-heads", heads);
> This looks like the wrong place to do this calculation.  You overwrite what
has
> been put into quantized-positions here.  It looks like you should rather move
> the calculation to the place where quantized-positions is initialized,

Agreed. However, I cannot figure out where the appropriate place for these
calculations should be.

[aleksandr.andreev, 2012-09-10 00:13:50]

Please review.