Issue 6305066: BasicOAuth2Store calling getToken with incorrect URI

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6305066: BasicOAuth2Store calling getToken with incorrect URI (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 2 months ago by btlillie

Modified:
13 years, 2 months ago

Reviewers:
Stanton, dev, clakre

Base URL:
http://svn.apache.org/repos/asf/shindig/trunk/

Visibility:
Public.

Description

CR for SHINDIG-1791 BasicOAuth2Store setToken converts the gadget URI and serviceName into a processed name for shared clients. This processed name is then passed to getToken. The change is to pass the original gadget URI to getToken, since it will perform the same processing step.

Patch Set 1 #

Created: 13 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+72 lines, -1 line)			Patch
		java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/BasicOAuth2Store.java	View		1 chunk	+1 line, -1 line	0 comments	Download
		java/gadgets/src/test/java/org/apache/shindig/gadgets/oauth2/BasicOAuth2StoreTest.java	View		1 chunk	+71 lines, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

clakre

On 2012/06/08 11:12:28, Stanton wrote: > Ship it! Looks good to me too, Ship it!

13 years, 2 months ago (2012-06-08 11:24:16 UTC) #4

Committed revision 1348118.

Expand All Messages | Collapse All Messages