Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1426)

Issue 6304070: Duplicate uniform array passed to 2-point radial gradient (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 5 months ago by TomH
Modified:
12 years, 5 months ago
Reviewers:
DerekS, EricB, bsalomon
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

I believe Eric reported that this fixes the Xoom crash. Now, how long it takes to get this out to Clank? In the long term, Brian and I would like to do this beneath the hood, but that's not on my immediate todo list.

Patch Set 1 #

Patch Set 2 : Fix comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -18 lines) Patch
M src/gpu/effects/GrGradientEffects.cpp View 1 7 chunks +31 lines, -18 lines 0 comments Download

Messages

Total messages: 5
TomH
Here's a patch for the Xoom Radial2 failure.
12 years, 5 months ago (2012-06-12 21:44:06 UTC) #1
EricB
On 2012/06/12 21:44:06, TomH wrote: > Here's a patch for the Xoom Radial2 failure. There ...
12 years, 5 months ago (2012-06-13 12:01:48 UTC) #2
DerekS
On 2012/06/13 12:01:48, EricB wrote: > On 2012/06/12 21:44:06, TomH wrote: > > Here's a ...
12 years, 5 months ago (2012-06-13 12:17:05 UTC) #3
bsalomon
LGTM
12 years, 5 months ago (2012-06-13 13:10:23 UTC) #4
TomH
12 years, 5 months ago (2012-06-13 15:22:22 UTC) #5
Closed with r4246.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b