Shindig's Caja integration is using a year-old version of Caja, and doesn't really work because of bad interaction with Closure compiler.
This patch updates Shindig to use a recent version of Caja.
With this patch, the SocialActivitiesWorld demo works with or without Caja enabled.
LGTM http://codereview.appspot.com/6304061/diff/1/features/src/main/javascript/features/caja/taming.js File features/src/main/javascript/features/caja/taming.js (right): http://codereview.appspot.com/6304061/diff/1/features/src/main/javascript/features/caja/taming.js#newcode128 features/src/main/javascript/features/caja/taming.js:128: debug: true For my understanding, what breaks when ...
13 years, 2 months ago
(2012-06-11 15:22:41 UTC)
#2
I think JS compiler decorate the incoming request to always treat it as debug mode ...
13 years, 2 months ago
(2012-06-21 21:45:24 UTC)
#4
I think JS compiler decorate the incoming request to always treat it as debug
mode
On 2012/06/21 21:29:17, felix8a wrote:
> On 2012/06/11 15:22:41, Jasvir wrote:
> > LGTM
> >
> >
>
http://codereview.appspot.com/6304061/diff/1/features/src/main/javascript/fea...
> > File features/src/main/javascript/features/caja/taming.js (right):
> >
> >
>
http://codereview.appspot.com/6304061/diff/1/features/src/main/javascript/fea...
> > features/src/main/javascript/features/caja/taming.js:128: debug: true
> > For my understanding, what breaks when debug == false?
>
> debug:true is necessary at the moment to prevent shindig from
Closure-compiling
> Caja's taming-frame and guest-frame js, which breaks them. (eventually I'll
> have a better way of handling this.)
Issue 6304061: update shindig-caja integration
(Closed)
Created 13 years, 2 months ago by felix8a
Modified 13 years, 2 months ago
Reviewers: Jasvir, henry.saputra
Base URL: https://svn.apache.org/repos/asf/shindig/trunk/
Comments: 1