Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(40)

Issue 6304061: update shindig-caja integration (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 2 months ago by felix8a
Modified:
13 years, 2 months ago
Reviewers:
henry.saputra, Jasvir
CC:
dev_shindig.apache.org
Base URL:
https://svn.apache.org/repos/asf/shindig/trunk/
Visibility:
Public.

Description

Shindig's Caja integration is using a year-old version of Caja, and doesn't really work because of bad interaction with Closure compiler. This patch updates Shindig to use a recent version of Caja. With this patch, the SocialActivitiesWorld demo works with or without Caja enabled.

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+207 lines, -219 lines) Patch
D features/src/main/javascript/features/caja-debug/feature.xml View 1 chunk +0 lines, -28 lines 0 comments Download
D features/src/main/javascript/features/caja-guest-frame/feature.xml View 1 chunk +0 lines, -26 lines 0 comments Download
D features/src/main/javascript/features/caja-taming-frame/feature.xml View 1 chunk +0 lines, -26 lines 0 comments Download
A features/src/main/javascript/features/caja/caja-debug.xml View 1 chunk +27 lines, -0 lines 0 comments Download
A features/src/main/javascript/features/caja/es53-guest-frame.xml View 1 chunk +26 lines, -0 lines 0 comments Download
A features/src/main/javascript/features/caja/es53-guest-frame.opt.xml View 1 chunk +26 lines, -0 lines 0 comments Download
A features/src/main/javascript/features/caja/es53-taming-frame.xml View 1 chunk +26 lines, -0 lines 0 comments Download
A features/src/main/javascript/features/caja/es53-taming-frame.opt.xml View 1 chunk +26 lines, -0 lines 0 comments Download
M features/src/main/javascript/features/caja/feature.xml View 1 chunk +3 lines, -4 lines 0 comments Download
M features/src/main/javascript/features/caja/taming.js View 6 chunks +46 lines, -119 lines 1 comment Download
M features/src/main/javascript/features/core.json/taming.js View 1 chunk +2 lines, -4 lines 0 comments Download
M features/src/main/javascript/features/features.txt View 1 chunk +5 lines, -3 lines 0 comments Download
M features/src/main/javascript/features/gadgets.json.ext/taming.js View 1 chunk +4 lines, -2 lines 0 comments Download
M features/src/main/javascript/features/osapi.base/osapi.js View 1 chunk +3 lines, -3 lines 0 comments Download
M features/src/main/javascript/features/osapi.base/taming.js View 1 chunk +1 line, -1 line 0 comments Download
M java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/CajaContentRewriterTest.java View 1 chunk +1 line, -1 line 0 comments Download
M java/server/src/test/java/org/apache/shindig/server/endtoend/AllJsFilter.java View 2 chunks +10 lines, -1 line 0 comments Download
M pom.xml View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5
felix8a
ok, rebased from trunk and uploaded here, since https://reviews.apache.org/r/5202/ is down
13 years, 2 months ago (2012-06-09 22:55:31 UTC) #1
Jasvir
LGTM http://codereview.appspot.com/6304061/diff/1/features/src/main/javascript/features/caja/taming.js File features/src/main/javascript/features/caja/taming.js (right): http://codereview.appspot.com/6304061/diff/1/features/src/main/javascript/features/caja/taming.js#newcode128 features/src/main/javascript/features/caja/taming.js:128: debug: true For my understanding, what breaks when ...
13 years, 2 months ago (2012-06-11 15:22:41 UTC) #2
felix8a
On 2012/06/11 15:22:41, Jasvir wrote: > LGTM > > http://codereview.appspot.com/6304061/diff/1/features/src/main/javascript/features/caja/taming.js > File features/src/main/javascript/features/caja/taming.js (right): > ...
13 years, 2 months ago (2012-06-21 21:29:17 UTC) #3
henry.saputra
I think JS compiler decorate the incoming request to always treat it as debug mode ...
13 years, 2 months ago (2012-06-21 21:45:24 UTC) #4
felix8a
13 years, 2 months ago (2012-06-21 22:30:57 UTC) #5
@r1352717
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b