Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(151)

Issue 6303091: Convert usage of Flatland forms (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 1 month ago by xiaq
Modified:
13 years ago
Reviewers:
jek, thomas.j.waldmann, Reimar Bauer
Visibility:
Public.

Description

Convert usage of Flatland forms: http://etherpad.osuosl.org/moin-refactor-forms

Patch Set 1 #

Total comments: 9

Patch Set 2 : Various fixes #

Total comments: 2

Patch Set 3 : Almost completed the conversion; adjusted source structure #

Patch Set 4 : more conversion #

Total comments: 24

Patch Set 5 : Address issues mentioned in comments for patch set 4. #

Total comments: 2

Patch Set 6 : Many more conversions (including entire forms) #

Total comments: 10

Patch Set 7 : cleanups and fixes #

Total comments: 3

Patch Set 8 : remove form widgets from this patch set, addressing known issues #

Total comments: 9

Patch Set 9 : address mentioned issues #

Total comments: 1

Patch Set 10 : address mentioned issues #

Patch Set 11 : random tweaks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+389 lines, -232 lines) Patch
M MoinMoin/apps/frontend/views.py View 1 2 3 4 5 6 7 8 9 10 13 chunks +78 lines, -91 lines 0 comments Download
A MoinMoin/constants/forms.py View 1 2 3 4 5 6 7 8 9 10 1 chunk +31 lines, -0 lines 0 comments Download
A MoinMoin/forms.py View 1 2 3 4 5 6 7 8 1 chunk +72 lines, -0 lines 0 comments Download
M MoinMoin/items/__init__.py View 1 2 3 4 5 6 7 8 9 10 3 chunks +9 lines, -5 lines 0 comments Download
M MoinMoin/search/__init__.py View 1 2 3 4 5 6 7 2 chunks +4 lines, -3 lines 0 comments Download
M MoinMoin/templates/delete.html View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M MoinMoin/templates/destroy.html View 1 2 3 4 2 chunks +4 lines, -4 lines 0 comments Download
M MoinMoin/templates/forms.html View 1 2 3 4 5 6 7 3 chunks +109 lines, -51 lines 0 comments Download
M MoinMoin/templates/index.html View 1 2 3 4 5 6 7 8 2 chunks +13 lines, -9 lines 0 comments Download
M MoinMoin/templates/login.html View 1 2 2 chunks +5 lines, -8 lines 0 comments Download
M MoinMoin/templates/lookup.html View 1 2 3 4 5 6 7 8 9 1 chunk +15 lines, -11 lines 0 comments Download
M MoinMoin/templates/lostpass.html View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M MoinMoin/templates/modify_applet.html View 1 2 1 chunk +1 line, -1 line 0 comments Download
M MoinMoin/templates/modify_binary.html View 1 2 3 4 5 6 7 1 chunk +2 lines, -2 lines 0 comments Download
M MoinMoin/templates/openid_register.html View 1 2 1 chunk +5 lines, -6 lines 0 comments Download
M MoinMoin/templates/recoverpass.html View 1 2 3 4 5 6 7 1 chunk +5 lines, -5 lines 0 comments Download
M MoinMoin/templates/register.html View 1 2 1 chunk +6 lines, -6 lines 0 comments Download
M MoinMoin/templates/rename.html View 1 2 3 4 1 chunk +3 lines, -3 lines 0 comments Download
M MoinMoin/templates/revert.html View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M MoinMoin/templates/search.html View 1 2 3 4 5 6 1 chunk +3 lines, -3 lines 0 comments Download
M MoinMoin/templates/usersettings_forms.html View 1 2 3 6 7 5 chunks +17 lines, -17 lines 0 comments Download

Messages

Total messages: 23
xiaq
13 years, 1 month ago (2012-06-16 09:47:51 UTC) #1
ThomasJWaldmann
http://codereview.appspot.com/6303091/diff/1/MoinMoin/apps/frontend/views.py File MoinMoin/apps/frontend/views.py (right): http://codereview.appspot.com/6303091/diff/1/MoinMoin/apps/frontend/views.py#newcode469 MoinMoin/apps/frontend/views.py:469: comment = OptionalText.using(label=L_('Comment')).with_properties(placeholder=L_("Comment about your change")) if it is ...
13 years, 1 month ago (2012-06-16 11:54:30 UTC) #2
xiaq
http://codereview.appspot.com/6303091/diff/1/MoinMoin/apps/frontend/views.py File MoinMoin/apps/frontend/views.py (right): http://codereview.appspot.com/6303091/diff/1/MoinMoin/apps/frontend/views.py#newcode53 MoinMoin/apps/frontend/views.py:53: from MoinMoin.apps.frontend.forms import Text, OptionalText, Submit I left out ...
13 years, 1 month ago (2012-06-16 12:11:40 UTC) #3
ThomasJWaldmann
http://codereview.appspot.com/6303091/diff/5001/MoinMoin/templates/forms.html File MoinMoin/templates/forms.html (right): http://codereview.appspot.com/6303091/diff/5001/MoinMoin/templates/forms.html#newcode127 MoinMoin/templates/forms.html:127: 'text': annotated_input, 'submit': raw_input, 1 k/v per line please ...
13 years, 1 month ago (2012-06-16 12:32:58 UTC) #4
Reimar Bauer
some comments http://codereview.appspot.com/6303091/diff/4007/MoinMoin/apps/frontend/forms.py File MoinMoin/apps/frontend/forms.py (right): http://codereview.appspot.com/6303091/diff/4007/MoinMoin/apps/frontend/forms.py#newcode17 MoinMoin/apps/frontend/forms.py:17: "Enter a short comment about your change!" ...
13 years, 1 month ago (2012-06-17 08:02:35 UTC) #5
ThomasJWaldmann
http://codereview.appspot.com/6303091/diff/4007/MoinMoin/apps/frontend/forms.py File MoinMoin/apps/frontend/forms.py (right): http://codereview.appspot.com/6303091/diff/4007/MoinMoin/apps/frontend/forms.py#newcode7 MoinMoin/apps/frontend/forms.py:7: General Flatland forms containing hints for the templates. is ...
13 years, 1 month ago (2012-06-17 12:47:45 UTC) #6
xiaq
http://codereview.appspot.com/6303091/diff/4007/MoinMoin/apps/frontend/forms.py File MoinMoin/apps/frontend/forms.py (right): http://codereview.appspot.com/6303091/diff/4007/MoinMoin/apps/frontend/forms.py#newcode7 MoinMoin/apps/frontend/forms.py:7: General Flatland forms containing hints for the templates. On ...
13 years, 1 month ago (2012-06-18 02:49:51 UTC) #7
ThomasJWaldmann
please also try all the stuff you changed. run py.test. http://codereview.appspot.com/6303091/diff/4007/MoinMoin/apps/frontend/forms.py File MoinMoin/apps/frontend/forms.py (right): http://codereview.appspot.com/6303091/diff/4007/MoinMoin/apps/frontend/forms.py#newcode17 ...
13 years, 1 month ago (2012-06-18 08:07:02 UTC) #8
xiaq
On 2012/06/18 08:07:02, ThomasJWaldmann wrote: > please also try all the stuff you changed. > ...
13 years, 1 month ago (2012-06-18 13:52:24 UTC) #9
xiaq
http://codereview.appspot.com/6303091/diff/4007/MoinMoin/apps/frontend/forms.py File MoinMoin/apps/frontend/forms.py (right): http://codereview.appspot.com/6303091/diff/4007/MoinMoin/apps/frontend/forms.py#newcode17 MoinMoin/apps/frontend/forms.py:17: On 2012/06/18 08:07:02, ThomasJWaldmann wrote: > As this is ...
13 years, 1 month ago (2012-06-18 13:52:42 UTC) #10
xiaq
Patch set 6 just uploaded. Please review! :) This is what I've made so far ...
13 years, 1 month ago (2012-06-19 11:40:54 UTC) #11
ThomasJWaldmann
http://codereview.appspot.com/6303091/diff/6007/MoinMoin/apps/frontend/views.py File MoinMoin/apps/frontend/views.py (right): http://codereview.appspot.com/6303091/diff/6007/MoinMoin/apps/frontend/views.py#newcode1389 MoinMoin/apps/frontend/views.py:1389: email = email.with_properties(helper=L_("Changing your email address requires you to ...
13 years, 1 month ago (2012-06-19 13:22:14 UTC) #12
xiaq
http://codereview.appspot.com/6303091/diff/6007/MoinMoin/apps/frontend/views.py File MoinMoin/apps/frontend/views.py (right): http://codereview.appspot.com/6303091/diff/6007/MoinMoin/apps/frontend/views.py#newcode1452 MoinMoin/apps/frontend/views.py:1452: if form['name_'].value != flaskg.user.name and user.search_users(name_exact=form['name_'].value): On 2012/06/19 13:22:15, ...
13 years, 1 month ago (2012-06-19 14:25:50 UTC) #13
ThomasJWaldmann
2 comments, one on cs6 and one on cs7 http://codereview.appspot.com/6303091/diff/6007/MoinMoin/forms.py File MoinMoin/forms.py (right): http://codereview.appspot.com/6303091/diff/6007/MoinMoin/forms.py#newcode143 MoinMoin/forms.py:143: ...
13 years, 1 month ago (2012-06-21 12:00:19 UTC) #14
jek
This looks great! http://codereview.appspot.com/6303091/diff/1021/MoinMoin/forms.py File MoinMoin/forms.py (right): http://codereview.appspot.com/6303091/diff/1021/MoinMoin/forms.py#newcode68 MoinMoin/forms.py:68: Hidden = String.with_properties(widget=WIDGET_HIDDEN, optional=True) Should this ...
13 years, 1 month ago (2012-06-23 16:49:18 UTC) #15
xiaq
On 2012/06/23 16:49:18, jek wrote: > This looks great! > There seems to be not ...
13 years, 1 month ago (2012-06-25 05:30:27 UTC) #16
xiaq
http://codereview.appspot.com/6303091/diff/1021/MoinMoin/forms.py File MoinMoin/forms.py (right): http://codereview.appspot.com/6303091/diff/1021/MoinMoin/forms.py#newcode68 MoinMoin/forms.py:68: Hidden = String.with_properties(widget=WIDGET_HIDDEN, optional=True) On 2012/06/23 16:49:18, jek wrote: ...
13 years, 1 month ago (2012-06-25 05:30:39 UTC) #17
ThomasJWaldmann
http://codereview.appspot.com/6303091/diff/31001/MoinMoin/apps/frontend/forms.py File MoinMoin/apps/frontend/forms.py (right): http://codereview.appspot.com/6303091/diff/31001/MoinMoin/apps/frontend/forms.py#newcode15 MoinMoin/apps/frontend/forms.py:15: if this stuff is just used at one place, ...
13 years, 1 month ago (2012-07-01 06:30:06 UTC) #18
xiaq
http://codereview.appspot.com/6303091/diff/31001/MoinMoin/apps/frontend/forms.py File MoinMoin/apps/frontend/forms.py (right): http://codereview.appspot.com/6303091/diff/31001/MoinMoin/apps/frontend/forms.py#newcode15 MoinMoin/apps/frontend/forms.py:15: On 2012/07/01 06:30:06, ThomasJWaldmann wrote: > if this stuff ...
13 years, 1 month ago (2012-07-01 13:45:39 UTC) #19
Reimar Bauer
http://codereview.appspot.com/6303091/diff/40005/MoinMoin/templates/lookup.html File MoinMoin/templates/lookup.html (right): http://codereview.appspot.com/6303091/diff/40005/MoinMoin/templates/lookup.html#newcode10 MoinMoin/templates/lookup.html:10: {{ forms.render(lookup_form['name']) }} Why no loop over a list ...
13 years, 1 month ago (2012-07-02 08:09:10 UTC) #20
ThomasJWaldmann
looks ok to me now. please do a "make test" and if ok, do some ...
13 years ago (2012-07-03 16:11:52 UTC) #21
xiaq
On 2012/07/03 16:11:52, ThomasJWaldmann wrote: > looks ok to me now. > > please do ...
13 years ago (2012-07-04 03:46:44 UTC) #22
ThomasJWaldmann
13 years ago (2012-07-05 12:22:15 UTC) #23
"do some clean changesets" was not intended to say that the current stuff is
unclean, was just intended to make you think about it.

so commit when you are ready with it.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b