Issue 6303086: code review 6303086: go/ast: minor comment maps API change

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6303086: code review 6303086: go/ast: minor comment maps API change (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 12 months ago by gri

Modified:
13 years, 11 months ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

go/ast: minor comment maps API change This is a new, not yet committed API. - Changed NewCommentMap to be independent of *File nodes and more symmetric with the Filter and Comments methods. - Implemented Update method for use in AST modifications. - Implemented String method for debugging

Patch Set 1 #

Patch Set 2 : diff -r 47e7c99fbe87 https://code.google.com/p/go #

Patch Set 3 : diff -r 47e7c99fbe87 https://code.google.com/p/go #

Patch Set 4 : diff -r 47e7c99fbe87 https://code.google.com/p/go #

Patch Set 5 : diff -r 47e7c99fbe87 https://code.google.com/p/go #

Patch Set 6 : diff -r 5e3661048f2e https://code.google.com/p/go #

Total comments: 2

Patch Set 7 : diff -r 0a6c79a8aa2d https://code.google.com/p/go #

Created: 13 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+86 lines, -22 lines)			Patch
M	src/cmd/godoc/godoc.go	View	1 2 3 4 5	1 chunk	+1 line, -1 line	0 comments	Download
M	src/cmd/godoc/main.go	View	1 2 3 4 5	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/go/ast/commentmap.go	View	1 2 3 4 5 6	5 chunks	+83 lines, -19 lines	0 comments	Download
M	src/pkg/go/ast/commentmap_test.go	View	1 2 3 4 5	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

gri

Hello rsc@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go

13 years, 12 months ago (2012-06-15 21:09:47 UTC) #1

rsc

LGTM http://codereview.appspot.com/6303086/diff/8001/src/pkg/go/ast/commentmap.go File src/pkg/go/ast/commentmap.go (right): http://codereview.appspot.com/6303086/diff/8001/src/pkg/go/ast/commentmap.go#newcode243 src/pkg/go/ast/commentmap.go:243: // and returns the new node. Comments that ...

13 years, 11 months ago (2012-06-25 14:14:48 UTC) #2

gri

13 years, 11 months ago (2012-06-25 18:28:01 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=db559a037266 ***

go/ast: minor comment maps API change

This is a new, not yet committed API.

- Changed NewCommentMap to be independent of
  *File nodes and more symmetric with the
  Filter and Comments methods.

- Implemented Update method for use in
  AST modifications.

- Implemented String method for debugging

R=rsc
CC=golang-dev
http://codereview.appspot.com/6303086

Expand All Messages | Collapse All Messages